Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enhance fileUpload modal and fixing behaviour of modals. #891

Open
thepiyush-303 opened this issue Jan 13, 2025 · 6 comments · May be fixed by #899
Open

fix: Enhance fileUpload modal and fixing behaviour of modals. #891

thepiyush-303 opened this issue Jan 13, 2025 · 6 comments · May be fixed by #899
Labels
bug Something isn't working

Comments

@thepiyush-303
Copy link
Contributor

thepiyush-303 commented Jan 13, 2025

Description:

fix/include all the behaviour in all modal as what RC follows, and include all the styling in the upload-File modal.

Tasks:

  1. adding css to file-Upload modal.
  2. showing error if required filed is empty.
  3. access fields through labels.

Actual behavior:

Screencast.from.2025-01-15.00-33-09.webm
@thepiyush-303 thepiyush-303 added the bug Something isn't working label Jan 13, 2025
@thepiyush-303 thepiyush-303 reopened this Jan 13, 2025
@thepiyush-303 thepiyush-303 changed the title fix: Enhance file upload modal. fix: clicking outside any modal should close that modal. Jan 13, 2025
@thepiyush-303 thepiyush-303 changed the title fix: clicking outside any modal should close that modal. fix: Enhance fileUpload modal Jan 13, 2025
@thepiyush-303 thepiyush-303 changed the title fix: Enhance fileUpload modal fix: Enhance fileUpload modal and fixing behaviour of modals. Jan 13, 2025
@dhairyashiil
Copy link
Contributor

Hello @thepiyush-303, can you please specify exactly what you are working on? I'm working on the File Upload Window so that we don't work on the same things.

@thepiyush-303
Copy link
Contributor Author

I'll add all the behaviour of modals which also followed by RC.

@dhairyashiil
Copy link
Contributor

I'll add all the behaviour of modals which also followed by RC.

Sorry Piyush, it's a little bit confusing to understand. Can you list down these behaviors?

@abirc8010
Copy link
Contributor

I'll implement all the behavior for modals as specified in the RC.

@thepiyush-303, could you please attach a video and complete the issue template? That would make it clearer what issue you are referring to.

@thepiyush-303
Copy link
Contributor Author

Can you list down these behaviors?

  1. adding css to file-Upload modal.
  2. showing error if required filed is empty.
  3. adding esc and clicking outside of add link modal should close the modal.

I will add above behaviour.

@thepiyush-303
Copy link
Contributor Author

could you please attach a video and complete the issue template? That would make it clearer what issue you are referring to.

will add them soon.

@thepiyush-303 thepiyush-303 linked a pull request Jan 14, 2025 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants