From 872e42ce01229a0fd51e45b8b2684b654e3716b4 Mon Sep 17 00:00:00 2001 From: Clinton Graham Date: Wed, 22 Jan 2025 09:43:47 -0600 Subject: [PATCH 1/2] #376: Update LinkResolverView to use permanent redirects --- process_request/views.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/process_request/views.py b/process_request/views.py index aab9059..ee600a3 100644 --- a/process_request/views.py +++ b/process_request/views.py @@ -136,7 +136,7 @@ def get(self, request): host = settings.DIMES_BASEURL repo = settings.ARCHIVESSPACE["repo_id"] uri = resolve_ref_id(repo, data, aspace.client) - response = redirect("{}{}".format(host, uri)) + response = redirect("{}{}".format(host, uri), permanent=True) return response except Exception as e: return Response({"detail": str(e)}, status=500) From 84e91f657f185d0e9a021756134cc32316e95e0a Mon Sep 17 00:00:00 2001 From: Hillel Arnold Date: Wed, 22 Jan 2025 14:49:21 -0500 Subject: [PATCH 2/2] update status code --- process_request/tests.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/process_request/tests.py b/process_request/tests.py index 0810f37..471f1ac 100644 --- a/process_request/tests.py +++ b/process_request/tests.py @@ -564,7 +564,7 @@ def test_linkresolver_view(self, mock_resolve): mock_refid = "12345abcdef" mock_resolve.return_value = mock_uri response = self.client.get(reverse('resolve-request'), {"ref_id": mock_refid}) - self.assertEqual(response.status_code, 302) + self.assertEqual(response.status_code, 301) self.assertEqual(response.url, f"{settings.DIMES_BASEURL}{mock_uri}") mock_resolve.assert_called_with(settings.ARCHIVESSPACE["repo_id"], mock_refid, ANY)