You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This naming conflicts make it really difficult to build up and retain mental model of the implementation logic.
I think Tuple and Fact also describe same concept but in different contexts and two names here which makes things even more confusing.
Impact
Makes it difficult to learn and contribute to the project.
Solution
Rename Fact so it does not collide with a name "fact" when referencing EAVT tuples. I would propose calling it Association as it associates multiple attributes and makes intuitive sense to me. Alternative it can be called GroundAtom which would be very clear reference to a terminology used in the spec.
Avoid name Tuple given how overloaded it is, even EAVTs are frequently referred as tuples (even spec the spec does it). Again I think Association seems like an intuitive term for me but anything less overloaded would do.
Assuming Tuple and Fact do indeed refer to the concept of "ground atom" in different contexts it would be good to use same name (e.g. there are multiple Program types for different contexts) or alternatively have same term with different suffix.
The text was updated successfully, but these errors were encountered:
Summary
Implementation defines types
Tuple
andFact
to describe what I believe PomoLogic calls ground atom. This gets even more confusing given that PomoDB calls EAVT (4-tuples) factsProblem
Tuple
andFact
also describe same concept but in different contexts and two names here which makes things even more confusing.Impact
Makes it difficult to learn and contribute to the project.
Solution
Fact
so it does not collide with a name "fact" when referencing EAVT tuples. I would propose calling itAssociation
as it associates multiple attributes and makes intuitive sense to me. Alternative it can be calledGroundAtom
which would be very clear reference to a terminology used in the spec.Tuple
given how overloaded it is, even EAVTs are frequently referred as tuples (even spec the spec does it). Again I thinkAssociation
seems like an intuitive term for me but anything less overloaded would do.Tuple
andFact
do indeed refer to the concept of "ground atom" in different contexts it would be good to use same name (e.g. there are multipleProgram
types for different contexts) or alternatively have same term with different suffix.The text was updated successfully, but these errors were encountered: