From 869341c7f527d4499e2c551a0d83b939ef4f52a3 Mon Sep 17 00:00:00 2001 From: Gokhan Kurt Date: Tue, 9 Apr 2024 17:47:40 +0300 Subject: [PATCH] switch to ubuntu-latest and remove Unity 2019 --- .github/workflows/test.yml | 7 +------ Runtime/Yoga/YogaNode.cs | 5 +---- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index bf97d02b..8466d31d 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -31,12 +31,11 @@ jobs: fail-fast: false matrix: platform: - - ubuntu-20.04 + - ubuntu-latest unity: - { version: "2021.3.28f1" } - { version: "2021.1.28f1" } - { version: "2020.3.43f1" } - - { version: "2019.4.40f1" } suite: - { name: "Unit Tests", @@ -117,10 +116,6 @@ jobs: echo $(cat tests/Packages/manifest.json | jq '.dependencies["com.reactunity.quickjs"]="file:../../quickjs"') > tests/Packages/manifest.json echo $(cat tests/Packages/manifest.json | jq '.dependencies["com.reactunity.clearscript"]="file:../../clearscript"') > tests/Packages/manifest.json - - name: Install TMP v2 - if: startsWith(matrix.unity.version, '2019') - run: echo $(cat tests/Packages/manifest.json | jq '.dependencies["com.unity.textmeshpro"]="2.1.6"') > tests/Packages/manifest.json - - name: Run Unity Tests uses: game-ci/unity-test-runner@v2 id: testRunner diff --git a/Runtime/Yoga/YogaNode.cs b/Runtime/Yoga/YogaNode.cs index 9359a6ae..8f846f7b 100644 --- a/Runtime/Yoga/YogaNode.cs +++ b/Runtime/Yoga/YogaNode.cs @@ -414,10 +414,7 @@ public void Clear() { if (_children != null) { - while (_children.Count > 0) - { - RemoveAt(_children.Count - 1); - } + RemoveAll(); } }