Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return brand logo in /info endpoint #92

Closed
BenjaminHalko opened this issue Sep 29, 2023 · 8 comments · Fixed by #102
Closed

feat: return brand logo in /info endpoint #92

BenjaminHalko opened this issue Sep 29, 2023 · 8 comments · Fixed by #102
Assignees
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@BenjaminHalko
Copy link
Member

This endpoint will return brand links for ReVanced.

@oSumAtrIX oSumAtrIX self-assigned this Sep 29, 2023
@oSumAtrIX oSumAtrIX added the Feature request Requesting a new feature that's not implemented yet label Sep 29, 2023
@oSumAtrIX oSumAtrIX moved this to 📋 Backlog in Development of ReVanced Sep 29, 2023
@Ushie
Copy link
Member

Ushie commented Sep 29, 2023

Can you clarify what "brand links" are? please show an example response

@oSumAtrIX
Copy link
Member

@Ushie

This comment was marked as resolved.

@Ushie Ushie changed the title feat: /branding endpoint feat: return brand logo in /info endpoint Sep 29, 2023
@alexandreteles
Copy link
Contributor

Looking into ReVanced/revanced-manager#1294 (comment) I'm not entirely sure of which information the endpoint /v2/info is expected to return. This seems to be a simple change, would you care to provide an example response that includes the changes you want to see implemented?

@oSumAtrIX
Copy link
Member

I'd say the info endpoint would have a branding object field with a field logo with a link to the logo being the value. In our specific case, the question would be where we would host the file. Lets wait for @BenjaminHalko.

@BenjaminHalko
Copy link
Member Author

I thought the API would just return what is in the revanced branding repo

@oSumAtrIX
Copy link
Member

How would that work internally?

@alexandreteles alexandreteles linked a pull request Oct 14, 2023 that will close this issue
@alexandreteles alexandreteles removed a link to a pull request Oct 14, 2023
@alexandreteles alexandreteles linked a pull request Oct 14, 2023 that will close this issue
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Development of ReVanced Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants