From c639a003454ad25b69824d9edd4b327bfec50be7 Mon Sep 17 00:00:00 2001 From: Anirban Date: Thu, 18 Apr 2024 12:48:38 -0700 Subject: [PATCH 01/11] Move tests to .ci, updated workflow version to accommodate that change, added a test, renamed test case titles --- {inst => .ci}/atime/tests.R | 20 ++++++++++++++++---- .github/workflows/performance-tests.yml | 2 +- 2 files changed, 17 insertions(+), 5 deletions(-) rename {inst => .ci}/atime/tests.R (86%) diff --git a/inst/atime/tests.R b/.ci/atime/tests.R similarity index 86% rename from inst/atime/tests.R rename to .ci/atime/tests.R index a0635d063..8092a6a9c 100644 --- a/inst/atime/tests.R +++ b/.ci/atime/tests.R @@ -73,7 +73,7 @@ pkg.edit.fun = function(old.Package, new.Package, sha, new.pkg.path) { test.list <- list( # Performance regression discussed in: https://github.com/Rdatatable/data.table/issues/4311 # Fixed in: https://github.com/Rdatatable/data.table/pull/4440 - "Test regression fixed in #4440" = list( + "Test performance regression fixed in #4440" = list( pkg.edit.fun = pkg.edit.fun, N = 10^seq(3,8), setup = quote({ @@ -88,8 +88,8 @@ test.list <- list( # Test based on: https://github.com/Rdatatable/data.table/issues/5424 # Performance regression introduced from a commit in: https://github.com/Rdatatable/data.table/pull/4491 - # Fixed in: https://github.com/Rdatatable/data.table/pull/5463 - "Test regression fixed in #5463" = list( + # Fixed in: https://github.com/Rdatatable/data.table/pull/5463 + "Test performance regression fixed in #5463" = list( pkg.edit.fun = pkg.edit.fun, N = 10^seq(3, 8), setup = quote({ @@ -104,5 +104,17 @@ test.list <- list( expr = quote(data.table:::`[.data.table`(dt_mod, , N := .N, by = g)), Before = "be2f72e6f5c90622fe72e1c315ca05769a9dc854", # Parent of the regression causing commit (https://github.com/Rdatatable/data.table/commit/e793f53466d99f86e70fc2611b708ae8c601a451) in the PR that introduced the issue (https://github.com/Rdatatable/data.table/pull/4491/commits) Regression = "e793f53466d99f86e70fc2611b708ae8c601a451", # Commit responsible for regression in the PR that introduced the issue (https://github.com/Rdatatable/data.table/pull/4491/commits) - Fixed = "58409197426ced4714af842650b0cc3b9e2cb842") # Last commit in the PR that fixed the regression (https://github.com/Rdatatable/data.table/pull/5463/commits) + Fixed = "58409197426ced4714af842650b0cc3b9e2cb842"), # Last commit in the PR that fixed the regression (https://github.com/Rdatatable/data.table/pull/5463/commits) + + # Issue reported in: https://github.com/Rdatatable/data.table/issues/5426 + # To be fixed in: https://github.com/Rdatatable/data.table/pull/5427 + "Test performance improvement implemented in #5427" = list( + pkg.edit.fun = pkg.edit.fun, + N = 10^seq(1, 7), + setup = quote({ + DT = replicate(N, 1, simplify = FALSE) + }), + expr = quote(data.table:::setDT(DT)), + Slow = "c4a2085e35689a108d67dacb2f8261e4964d7e12", # Parent of the first commit in the PR that fixes the issue (https://github.com/Rdatatable/data.table/commit/7cc4da4c1c8e568f655ab5167922dcdb75953801) + Fast = "1872f473b20fdcddc5c1b35d79fe9229cd9a1d15") # Last commit in the PR that fixes the issue (https://github.com/Rdatatable/data.table/pull/5427/commits) ) diff --git a/.github/workflows/performance-tests.yml b/.github/workflows/performance-tests.yml index 2fc3a76f5..15b5ece28 100644 --- a/.github/workflows/performance-tests.yml +++ b/.github/workflows/performance-tests.yml @@ -20,4 +20,4 @@ jobs: GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }} repo_token: ${{ secrets.GITHUB_TOKEN }} steps: - - uses: Anirban166/Autocomment-atime-results@v1.1.6 + - uses: Anirban166/Autocomment-atime-results@v1.2.0 From 0c0ce61c9a0c70e787e53b52cf326bb07a623d3f Mon Sep 17 00:00:00 2001 From: Ani Date: Thu, 18 Apr 2024 13:58:49 -0700 Subject: [PATCH 02/11] Added to the path filter to trigger the action on changes to the tests --- .github/workflows/performance-tests.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/performance-tests.yml b/.github/workflows/performance-tests.yml index 15b5ece28..1cbc38f9e 100644 --- a/.github/workflows/performance-tests.yml +++ b/.github/workflows/performance-tests.yml @@ -10,7 +10,8 @@ on: - synchronize paths: - 'R/**' - - 'src/**' + - 'src/**' + - '.ci/atime/tests.R' jobs: comment: From 28483e8f8f184ab04dbf3804ef0d70c8ebf0143a Mon Sep 17 00:00:00 2001 From: Ani Date: Thu, 18 Apr 2024 14:01:15 -0700 Subject: [PATCH 03/11] Avoid repetition in test case titles --- .ci/atime/tests.R | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.ci/atime/tests.R b/.ci/atime/tests.R index 8092a6a9c..b16eb2204 100644 --- a/.ci/atime/tests.R +++ b/.ci/atime/tests.R @@ -73,7 +73,7 @@ pkg.edit.fun = function(old.Package, new.Package, sha, new.pkg.path) { test.list <- list( # Performance regression discussed in: https://github.com/Rdatatable/data.table/issues/4311 # Fixed in: https://github.com/Rdatatable/data.table/pull/4440 - "Test performance regression fixed in #4440" = list( + "Regression fixed in #4440" = list( pkg.edit.fun = pkg.edit.fun, N = 10^seq(3,8), setup = quote({ @@ -89,7 +89,7 @@ test.list <- list( # Test based on: https://github.com/Rdatatable/data.table/issues/5424 # Performance regression introduced from a commit in: https://github.com/Rdatatable/data.table/pull/4491 # Fixed in: https://github.com/Rdatatable/data.table/pull/5463 - "Test performance regression fixed in #5463" = list( + "Regression fixed in #5463" = list( pkg.edit.fun = pkg.edit.fun, N = 10^seq(3, 8), setup = quote({ @@ -108,7 +108,7 @@ test.list <- list( # Issue reported in: https://github.com/Rdatatable/data.table/issues/5426 # To be fixed in: https://github.com/Rdatatable/data.table/pull/5427 - "Test performance improvement implemented in #5427" = list( + "Improvement implemented in #5427" = list( pkg.edit.fun = pkg.edit.fun, N = 10^seq(1, 7), setup = quote({ From a59ad449e67208efbdb53ea59140e1a39927cff1 Mon Sep 17 00:00:00 2001 From: Ani Date: Thu, 18 Apr 2024 14:49:31 -0700 Subject: [PATCH 04/11] Update .github/workflows/performance-tests.yml Co-authored-by: Michael Chirico --- .github/workflows/performance-tests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/performance-tests.yml b/.github/workflows/performance-tests.yml index 1cbc38f9e..cb30e7625 100644 --- a/.github/workflows/performance-tests.yml +++ b/.github/workflows/performance-tests.yml @@ -11,7 +11,7 @@ on: paths: - 'R/**' - 'src/**' - - '.ci/atime/tests.R' + - '.ci/atime/**' jobs: comment: From f4c5d28df39fc5f45e602b15b20a53b5ce52329c Mon Sep 17 00:00:00 2001 From: Ani Date: Fri, 19 Apr 2024 19:28:12 -0700 Subject: [PATCH 05/11] rm whitespace --- .ci/atime/tests.R | 37 +++++++++++++++++++------------------ 1 file changed, 19 insertions(+), 18 deletions(-) diff --git a/.ci/atime/tests.R b/.ci/atime/tests.R index b16eb2204..dcbf950ce 100644 --- a/.ci/atime/tests.R +++ b/.ci/atime/tests.R @@ -1,7 +1,7 @@ # A function to customize R package metadata and source files to facilitate version-specific installation and testing. # -# This is specifically tailored for handling data.table which requires specific changes in non-standard files (such as the object file name in Makevars and version checking code in onLoad.R) -# to support testing across different versions (base and HEAD for PRs, commits associated with historical regressions, etc.) of the package. +# This is specifically tailored for handling data.table which requires specific changes in non-standard files (such as the object file name in Makevars and version checking code in onLoad.R) +# to support testing across different versions (base and HEAD for PRs, commits associated with historical regressions, etc.) of the package. # It appends a SHA1 hash to the package name (PKG.SHA), ensuring each version can be installed and tested separately. # # @param old.Package Current name of the package. @@ -29,7 +29,7 @@ pkg.edit.fun = function(old.Package, new.Package, sha, new.pkg.path) { Package_ <- gsub(".", "_", old.Package, fixed = TRUE) new.Package_ <- paste0(Package_, "_", sha) pkg_find_replace( - "DESCRIPTION", + "DESCRIPTION", paste0("Package:\\s+", old.Package), paste("Package:", new.Package)) pkg_find_replace( @@ -55,13 +55,13 @@ pkg.edit.fun = function(old.Package, new.Package, sha, new.pkg.path) { } # A list of performance tests. -# +# # Each entry in this list corresponds to a performance test and contains a sublist with three mandatory arguments: # - N: A numeric sequence of data sizes to vary. # - setup: An expression evaluated for every data size before measuring time/memory. -# - expr: An expression that will be evaluated for benchmarking performance across different git commit versions. +# - expr: An expression that will be evaluated for benchmarking performance across different git commit versions. # This must call a function from data.table using a syntax with double or triple colon prefix. -# The package name before the colons will be replaced by a new package name that uses the commit SHA hash. +# The package name before the colons will be replaced by a new package name that uses the commit SHA hash. # (For instance, data.table:::[.data.table will become data.table.some_40_digit_SHA1_hash:::[.data.table) # # Optional parameters that may be useful to configure tests: @@ -70,10 +70,11 @@ pkg.edit.fun = function(old.Package, new.Package, sha, new.pkg.path) { # - sha.vec: Named character vector or a list of vectors that specify data.table-specific commit SHAs for testing across those different git commit versions. # For historical regressions, use 'Before', 'Regression', and 'Fixed' (otherwise something like 'Slow' or 'Fast' ideally). # @note Please check https://github.com/tdhock/atime/blob/main/vignettes/data.table.Rmd for more information. +# nolint start: undesirable_operator_linter. ':::' needed+appropriate here. test.list <- list( - # Performance regression discussed in: https://github.com/Rdatatable/data.table/issues/4311 + # Performance regression discussed in: https://github.com/Rdatatable/data.table/issues/4311 # Fixed in: https://github.com/Rdatatable/data.table/pull/4440 - "Regression fixed in #4440" = list( + "Test regression fixed in #4440" = list( pkg.edit.fun = pkg.edit.fun, N = 10^seq(3,8), setup = quote({ @@ -89,7 +90,7 @@ test.list <- list( # Test based on: https://github.com/Rdatatable/data.table/issues/5424 # Performance regression introduced from a commit in: https://github.com/Rdatatable/data.table/pull/4491 # Fixed in: https://github.com/Rdatatable/data.table/pull/5463 - "Regression fixed in #5463" = list( + "Test regression fixed in #5463" = list( pkg.edit.fun = pkg.edit.fun, N = 10^seq(3, 8), setup = quote({ @@ -101,7 +102,7 @@ test.list <- list( key = "g") dt_mod <- copy(dt) }), - expr = quote(data.table:::`[.data.table`(dt_mod, , N := .N, by = g)), + expr = quote(data.table:::`[.data.table`(dt_mod, , N := .N, by = g)), Before = "be2f72e6f5c90622fe72e1c315ca05769a9dc854", # Parent of the regression causing commit (https://github.com/Rdatatable/data.table/commit/e793f53466d99f86e70fc2611b708ae8c601a451) in the PR that introduced the issue (https://github.com/Rdatatable/data.table/pull/4491/commits) Regression = "e793f53466d99f86e70fc2611b708ae8c601a451", # Commit responsible for regression in the PR that introduced the issue (https://github.com/Rdatatable/data.table/pull/4491/commits) Fixed = "58409197426ced4714af842650b0cc3b9e2cb842"), # Last commit in the PR that fixed the regression (https://github.com/Rdatatable/data.table/pull/5463/commits) @@ -109,12 +110,12 @@ test.list <- list( # Issue reported in: https://github.com/Rdatatable/data.table/issues/5426 # To be fixed in: https://github.com/Rdatatable/data.table/pull/5427 "Improvement implemented in #5427" = list( - pkg.edit.fun = pkg.edit.fun, - N = 10^seq(1, 7), - setup = quote({ - DT = replicate(N, 1, simplify = FALSE) - }), - expr = quote(data.table:::setDT(DT)), - Slow = "c4a2085e35689a108d67dacb2f8261e4964d7e12", # Parent of the first commit in the PR that fixes the issue (https://github.com/Rdatatable/data.table/commit/7cc4da4c1c8e568f655ab5167922dcdb75953801) - Fast = "1872f473b20fdcddc5c1b35d79fe9229cd9a1d15") # Last commit in the PR that fixes the issue (https://github.com/Rdatatable/data.table/pull/5427/commits) + pkg.edit.fun = pkg.edit.fun, + N = 10^seq(1, 7), + setup = quote({ + DT = replicate(N, 1, simplify = FALSE) + }), + expr = quote(data.table:::setDT(DT)), + Slow = "c4a2085e35689a108d67dacb2f8261e4964d7e12", # Parent of the first commit in the PR that fixes the issue (https://github.com/Rdatatable/data.table/commit/7cc4da4c1c8e568f655ab5167922dcdb75953801) + Fast = "1872f473b20fdcddc5c1b35d79fe9229cd9a1d15") # Last commit in the PR that fixes the issue (https://github.com/Rdatatable/data.table/pull/5427/commits) ) From a2e91348fb8c37fb63be5ff1a52607ca5cd60140 Mon Sep 17 00:00:00 2001 From: Ani Date: Fri, 19 Apr 2024 19:29:18 -0700 Subject: [PATCH 06/11] Titles --- .ci/atime/tests.R | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.ci/atime/tests.R b/.ci/atime/tests.R index dcbf950ce..166dbfe08 100644 --- a/.ci/atime/tests.R +++ b/.ci/atime/tests.R @@ -74,7 +74,7 @@ pkg.edit.fun = function(old.Package, new.Package, sha, new.pkg.path) { test.list <- list( # Performance regression discussed in: https://github.com/Rdatatable/data.table/issues/4311 # Fixed in: https://github.com/Rdatatable/data.table/pull/4440 - "Test regression fixed in #4440" = list( + "Regression fixed in #4440" = list( pkg.edit.fun = pkg.edit.fun, N = 10^seq(3,8), setup = quote({ @@ -90,7 +90,7 @@ test.list <- list( # Test based on: https://github.com/Rdatatable/data.table/issues/5424 # Performance regression introduced from a commit in: https://github.com/Rdatatable/data.table/pull/4491 # Fixed in: https://github.com/Rdatatable/data.table/pull/5463 - "Test regression fixed in #5463" = list( + "Regression fixed in #5463" = list( pkg.edit.fun = pkg.edit.fun, N = 10^seq(3, 8), setup = quote({ From 51e4615d8ed9dbef6e600485d33f82ad616c72ba Mon Sep 17 00:00:00 2001 From: Ani Date: Mon, 22 Apr 2024 12:47:46 -0700 Subject: [PATCH 07/11] Reverted whitespace changes --- .ci/atime/tests.R | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/.ci/atime/tests.R b/.ci/atime/tests.R index 166dbfe08..27094ae53 100644 --- a/.ci/atime/tests.R +++ b/.ci/atime/tests.R @@ -1,7 +1,7 @@ # A function to customize R package metadata and source files to facilitate version-specific installation and testing. # -# This is specifically tailored for handling data.table which requires specific changes in non-standard files (such as the object file name in Makevars and version checking code in onLoad.R) -# to support testing across different versions (base and HEAD for PRs, commits associated with historical regressions, etc.) of the package. +# This is specifically tailored for handling data.table which requires specific changes in non-standard files (such as the object file name in Makevars and version checking code in onLoad.R) +# to support testing across different versions (base and HEAD for PRs, commits associated with historical regressions, etc.) of the package. # It appends a SHA1 hash to the package name (PKG.SHA), ensuring each version can be installed and tested separately. # # @param old.Package Current name of the package. @@ -29,7 +29,7 @@ pkg.edit.fun = function(old.Package, new.Package, sha, new.pkg.path) { Package_ <- gsub(".", "_", old.Package, fixed = TRUE) new.Package_ <- paste0(Package_, "_", sha) pkg_find_replace( - "DESCRIPTION", + "DESCRIPTION", paste0("Package:\\s+", old.Package), paste("Package:", new.Package)) pkg_find_replace( @@ -55,13 +55,13 @@ pkg.edit.fun = function(old.Package, new.Package, sha, new.pkg.path) { } # A list of performance tests. -# +# # Each entry in this list corresponds to a performance test and contains a sublist with three mandatory arguments: # - N: A numeric sequence of data sizes to vary. # - setup: An expression evaluated for every data size before measuring time/memory. -# - expr: An expression that will be evaluated for benchmarking performance across different git commit versions. +# - expr: An expression that will be evaluated for benchmarking performance across different git commit versions. # This must call a function from data.table using a syntax with double or triple colon prefix. -# The package name before the colons will be replaced by a new package name that uses the commit SHA hash. +# The package name before the colons will be replaced by a new package name that uses the commit SHA hash. # (For instance, data.table:::[.data.table will become data.table.some_40_digit_SHA1_hash:::[.data.table) # # Optional parameters that may be useful to configure tests: @@ -72,7 +72,7 @@ pkg.edit.fun = function(old.Package, new.Package, sha, new.pkg.path) { # @note Please check https://github.com/tdhock/atime/blob/main/vignettes/data.table.Rmd for more information. # nolint start: undesirable_operator_linter. ':::' needed+appropriate here. test.list <- list( - # Performance regression discussed in: https://github.com/Rdatatable/data.table/issues/4311 + # Performance regression discussed in: https://github.com/Rdatatable/data.table/issues/4311 # Fixed in: https://github.com/Rdatatable/data.table/pull/4440 "Regression fixed in #4440" = list( pkg.edit.fun = pkg.edit.fun, @@ -89,7 +89,7 @@ test.list <- list( # Test based on: https://github.com/Rdatatable/data.table/issues/5424 # Performance regression introduced from a commit in: https://github.com/Rdatatable/data.table/pull/4491 - # Fixed in: https://github.com/Rdatatable/data.table/pull/5463 + # Fixed in: https://github.com/Rdatatable/data.table/pull/5463 "Regression fixed in #5463" = list( pkg.edit.fun = pkg.edit.fun, N = 10^seq(3, 8), @@ -102,7 +102,7 @@ test.list <- list( key = "g") dt_mod <- copy(dt) }), - expr = quote(data.table:::`[.data.table`(dt_mod, , N := .N, by = g)), + expr = quote(data.table:::`[.data.table`(dt_mod, , N := .N, by = g)), Before = "be2f72e6f5c90622fe72e1c315ca05769a9dc854", # Parent of the regression causing commit (https://github.com/Rdatatable/data.table/commit/e793f53466d99f86e70fc2611b708ae8c601a451) in the PR that introduced the issue (https://github.com/Rdatatable/data.table/pull/4491/commits) Regression = "e793f53466d99f86e70fc2611b708ae8c601a451", # Commit responsible for regression in the PR that introduced the issue (https://github.com/Rdatatable/data.table/pull/4491/commits) Fixed = "58409197426ced4714af842650b0cc3b9e2cb842"), # Last commit in the PR that fixed the regression (https://github.com/Rdatatable/data.table/pull/5463/commits) From 1d8c69973256996beced9d66e0f54e46a0dc1c5e Mon Sep 17 00:00:00 2001 From: Ani Date: Mon, 22 Apr 2024 13:08:28 -0700 Subject: [PATCH 08/11] Removed the linter comment added from #5908 --- .ci/atime/tests.R | 1 - 1 file changed, 1 deletion(-) diff --git a/.ci/atime/tests.R b/.ci/atime/tests.R index 27094ae53..134f968e2 100644 --- a/.ci/atime/tests.R +++ b/.ci/atime/tests.R @@ -70,7 +70,6 @@ pkg.edit.fun = function(old.Package, new.Package, sha, new.pkg.path) { # - sha.vec: Named character vector or a list of vectors that specify data.table-specific commit SHAs for testing across those different git commit versions. # For historical regressions, use 'Before', 'Regression', and 'Fixed' (otherwise something like 'Slow' or 'Fast' ideally). # @note Please check https://github.com/tdhock/atime/blob/main/vignettes/data.table.Rmd for more information. -# nolint start: undesirable_operator_linter. ':::' needed+appropriate here. test.list <- list( # Performance regression discussed in: https://github.com/Rdatatable/data.table/issues/4311 # Fixed in: https://github.com/Rdatatable/data.table/pull/4440 From f23abda7f11bb35ca078a35e55cd4237f2372172 Mon Sep 17 00:00:00 2001 From: Ani Date: Tue, 23 Apr 2024 15:07:29 -0700 Subject: [PATCH 09/11] Fixed the third test --- .ci/atime/tests.R | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/.ci/atime/tests.R b/.ci/atime/tests.R index 77f9df75a..977821e3c 100644 --- a/.ci/atime/tests.R +++ b/.ci/atime/tests.R @@ -109,14 +109,18 @@ test.list <- list( # Issue reported in: https://github.com/Rdatatable/data.table/issues/5426 # To be fixed in: https://github.com/Rdatatable/data.table/pull/5427 - "Improvement implemented in #5427" = list( - pkg.edit.fun = pkg.edit.fun, - N = 10^seq(1, 7), - setup = quote({ - DT = replicate(N, 1, simplify = FALSE) - }), - expr = quote(data.table:::setDT(DT)), - Slow = "c4a2085e35689a108d67dacb2f8261e4964d7e12", # Parent of the first commit in the PR that fixes the issue (https://github.com/Rdatatable/data.table/commit/7cc4da4c1c8e568f655ab5167922dcdb75953801) - Fast = "1872f473b20fdcddc5c1b35d79fe9229cd9a1d15") # Last commit in the PR that fixes the issue (https://github.com/Rdatatable/data.table/pull/5427/commits) + "Test performance improvement implemented in #5427" = list( + pkg.edit.fun = pkg.edit.fun, + N = 10^seq(1, 7), + setup = quote({ + L <- replicate(N, 1, simplify = FALSE) + setDT(L) + }), + expr = quote({ + data.table:::setattr(L, "class", NULL) + data.table:::setDT(L) + }), + Slow = "c4a2085e35689a108d67dacb2f8261e4964d7e12", # Parent of the first commit in the PR that fixes the issue (https://github.com/Rdatatable/data.table/commit/7cc4da4c1c8e568f655ab5167922dcdb75953801) + Fast = "1872f473b20fdcddc5c1b35d79fe9229cd9a1d15") # Last commit in the PR that fixes the issue (https://github.com/Rdatatable/data.table/pull/5427/commits) ) # nolint end: undesirable_operator_linter. From 91b5de314e9674eaa5e23ca77e3408019fe75365 Mon Sep 17 00:00:00 2001 From: Ani Date: Tue, 23 Apr 2024 15:12:03 -0700 Subject: [PATCH 10/11] Titles --- .ci/atime/tests.R | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.ci/atime/tests.R b/.ci/atime/tests.R index 977821e3c..13011eb1c 100644 --- a/.ci/atime/tests.R +++ b/.ci/atime/tests.R @@ -74,7 +74,7 @@ pkg.edit.fun = function(old.Package, new.Package, sha, new.pkg.path) { test.list <- list( # Performance regression discussed in: https://github.com/Rdatatable/data.table/issues/4311 # Fixed in: https://github.com/Rdatatable/data.table/pull/4440 - "Regression fixed in #4440" = list( + "shallow regression fixed in #4440" = list( pkg.edit.fun = pkg.edit.fun, N = 10^seq(3,8), setup = quote({ @@ -90,7 +90,7 @@ test.list <- list( # Test based on: https://github.com/Rdatatable/data.table/issues/5424 # Performance regression introduced from a commit in: https://github.com/Rdatatable/data.table/pull/4491 # Fixed in: https://github.com/Rdatatable/data.table/pull/5463 - "Regression fixed in #5463" = list( + "memrecycle regression fixed in #5463" = list( pkg.edit.fun = pkg.edit.fun, N = 10^seq(3, 8), setup = quote({ @@ -109,7 +109,7 @@ test.list <- list( # Issue reported in: https://github.com/Rdatatable/data.table/issues/5426 # To be fixed in: https://github.com/Rdatatable/data.table/pull/5427 - "Test performance improvement implemented in #5427" = list( + "setDT improvement implemented in #5427" = list( pkg.edit.fun = pkg.edit.fun, N = 10^seq(1, 7), setup = quote({ From 6c7157d4277931f972a5b2c3f6bb24da4accece2 Mon Sep 17 00:00:00 2001 From: Ani Date: Tue, 23 Apr 2024 15:33:26 -0700 Subject: [PATCH 11/11] Better wording --- .ci/atime/tests.R | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.ci/atime/tests.R b/.ci/atime/tests.R index 13011eb1c..c5d2e3f25 100644 --- a/.ci/atime/tests.R +++ b/.ci/atime/tests.R @@ -109,7 +109,7 @@ test.list <- list( # Issue reported in: https://github.com/Rdatatable/data.table/issues/5426 # To be fixed in: https://github.com/Rdatatable/data.table/pull/5427 - "setDT improvement implemented in #5427" = list( + "setDT improved in #5427" = list( pkg.edit.fun = pkg.edit.fun, N = 10^seq(1, 7), setup = quote({