promote Ivan to committer?

[tdhock]

Hi @Rdatatable/committers
Ivan @aitap has been helping a lot in the last few months with several significant issues, PRs and reviews.
I would therefore consider Ivan a good candidate for promotion to committer, what do you think?
https://github.com/Rdatatable/data.table/blob/master/GOVERNANCE.md#committer says "after a reviewer has a consistent history of careful reviews of others' PRs, then a current Committer should ask all other current Committers if they approve promoting the Reviewer to Committer, and it should be done if there is Consensus among active Committers"
Ivan has done:
17 Reviews currently: https://github.com/Rdatatable/data.table/issues?q=reviewed-by%3Aaitap
22 issues/prs opened currently: https://github.com/Rdatatable/data.table/issues?q=author%3Aaitap%20

[tdhock]

Perhaps missing is that Ivan does not appear in https://github.com/Rdatatable/data.table/blob/master/CODEOWNERS
@aitap are there any files that you can volunteer to review?

[aitap]

Thank you for the very kind offer!

Judging by setdiff() between files I've touched and ones with a CODEOWNER, I could review src/chmatch.c or src/fread.c.

[tdhock]

thanks for volunteering to review chmatch.c and fread.c, please submit a PR to CODEOWNERS.

[MichaelChirico]

Perhaps missing

Should we edit the GOVERNANCE guidance to suggest CODEOWNERS-ship as a part of the Committer requirements?

As to the core issue, I certainly have no opposition to Ivan's promotion to committer! He has certainly satisfied the GOVERNANCE criteria. His expertise in several domains and careful reasoning is very welcome. Thank you!

[tdhock]

Thanks Michael.
My reading of governance is that we do not need to add any more about CODEOWNERS.
"after a reviewer has a consistent history of careful reviews" means that to be promoter to committer, you must be a reviewer, which is by definition somebody in CODEOWNERS. "a member should be invited to add their name as a reviewer of that file in CODEOWNERS, and after that is merged into master, then they are considered a reviewer."
https://github.com/Rdatatable/data.table/blob/master/GOVERNANCE.md#reviewer

[MichaelChirico]

Thanks! I guess then, that here we are doing a double-promotion, first to Reviewer (through CODEOWNERS change), then to Committer.

[jangorecki]

How long is Ivan already contributing to the project? First issue, and first PR?

[tdhock]

Ivan has been doing data.table-related PRs/issues since Aug 2024.
And base R contributions (on R-devel) long before that.

[jangorecki]

Sounds good then