Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test.data.table() fails if datatable.optimize is already set when run #3405

Closed
MichaelChirico opened this issue Feb 16, 2019 · 0 comments
Closed
Assignees

Comments

@MichaelChirico
Copy link
Member

From here there are tests which depend on options('datatable.optimize') but aren't careful to set/unset this before testing. Undetected since the default of datatable.optimize is set in onLoad.

Simply run:

library(data.table)
options(datatable.optimize = -1)
test.data.table()

There are 4 errors:

Error in test.data.table() :

4 errors out of 8368 in 35.9s elapsed (56.8s cpu) on Sat Feb 16 12:58:59 2019. [endian==little, sizeof(long double)==16, sizeof(pointer)==8, TZ=Asia/Singapore, locale='LC_CTYPE=en_US.UTF-8;LC_NUMERIC=C;LC_TIME=en_US.UTF-8;LC_COLLATE=en_US.UTF-8;LC_MONETARY=en_US.UTF-8;LC_MESSAGES=en_US.UTF-8;LC_PAPER=en_US.UTF-8;LC_NAME=C;LC_ADDRESS=C;LC_TELEPHONE=C;LC_MEASUREMENT=en_US.UTF-8;LC_IDENTIFICATION=C', l10n_info()='MBCS=TRUE; UTF-8=TRUE; Latin-1=FALSE']. Search tests/tests.Rraw for test numbers: 656, 657, 658, 865.

I'll try and tackle this alongside point 1 of #2572:

Tests involving GForce functions needs to be run with optimisation level 1 and 2, so that both functions are tested all the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant