Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: AddPeer #59

Open
HughIsaacs2 opened this issue Jul 15, 2020 · 1 comment
Open

Feature Request: AddPeer #59

HughIsaacs2 opened this issue Jul 15, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@HughIsaacs2
Copy link

HughIsaacs2 commented Jul 15, 2020 •
edited
Loading

It'd be awesome if this SDK had a WebTorrent style AddPeer feature for adding peers manually.

It'd be extra awesome if it accepted simple-peer instances too (like WebTorrent) for WebRTC peers.

EDIT: Also removePeer.
@RangerMauve
Copy link
Owner

RangerMauve commented Jul 16, 2020 •
edited
Loading

Ooo, that'd be awesome.

I think it'd be nice to have an API added to corestore-swarm-networking which accepted a duplex stream for connections (there's a private one already), and then expose that API inside the SDK.

From there you could use anything that provides a duplex stream including webrtc based stuff.

PRs would be very much welcome!

@RangerMauve RangerMauve added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Jul 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@RangerMauve @HughIsaacs2