-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refresh vega chart preview when local data file is changed and saved #61
Comments
I can do this for local data files, or just add a refresh button to reload referenced local and remote data ... |
Thanks for your quick feedback! I prefer the first option, because I only use local data files. Could you implement both? This would be the best solution for both local and remote data. |
yep! will do both in the next VV update. Could you please provide some public feedback on this extension in marketplace? I know that many Vega devs use it, yet the overall rating of it is super low for no good reason :) Thanks! |
Thank you. I provided feedback in the marketplace. |
+ added new Refresh data link button
@stenzengel thanks for that feedback in store. here is a pic of new refersh data UI and Vega Viewer toolbar now matching vscode theme colors. see #63 for more info on that ... I'll push new release with those changes tomorrow. |
@stenzengel actually, adding file watchers and automatically refreshing the chart on local data source changes might have some side effects when that data is live or log data. I am going to close this for now with refresh data feature implemented. |
@RandomFractals: Thanks for the refresh button and for trying to implement an automatic refresh for local data files. I do not completely understand the side effects you described, in particular what you mean by "data is live or log data". Would it help to be able to disable automatic refresh for these cases? I.e. would it help to have a vs code setting or a toggle button in the vega chart preview to enable/disable automatic refresh for local data files? Another option would be to "debounce" multiple refresh requests, if they occur too often (e.g. with https://rxjs-dev.firebaseapp.com/api/operators/debounceTime) |
@stenzengel I was just being lazy and figured Refresh will suffice. ok. I'll reopen it, add a setting to enable live data updates and add file watchers to do refresh on data file changes. No need for debounce, but thanks for that link :) |
@RandomFractals ;-) So am I: I'm too lazy to push the |
Currently the preview is not updated, when the data file referenced via url is changed and saved.
The file seems already to be known, because it can be opened in the preview. Would it be possible to listen to its save events and refresh the preview accordingly?
Many thanks for this extension!
The text was updated successfully, but these errors were encountered: