Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed multiplicand doesn't work #318

Open
Dr-WeiAL opened this issue Mar 3, 2022 · 8 comments
Open

Speed multiplicand doesn't work #318

Dr-WeiAL opened this issue Mar 3, 2022 · 8 comments
Assignees
Labels
🙏keep open modloader: Fabric type: 🐛 bug Something isn't working type: 🔄 mod compatibility Compatibility issues with other mods

Comments

@Dr-WeiAL
Copy link

Dr-WeiAL commented Mar 3, 2022

Describe the bug

When I set this configuration item to 1.0 or 2.0, nothing happens, it is exactly the same as when it is 0.0

Minecraft version

1.18.1

Fabric API version

0.46.4

Mod version

3.2.1

Relevant log output

latest.log

@Rakambda
Copy link
Member

Rakambda commented Mar 3, 2022

I see you have quite some mods loaded. Can you reproduce it with only FallingTree?

If you can't then it's probably an incompatibility with one of those mods and you'll have to fine tune it down to know which one.

@Dr-WeiAL
Copy link
Author

Dr-WeiAL commented Mar 7, 2022

I found out what the problem is, using it with Origins causes this problem

@Rakambda Rakambda added the type: 🔄 mod compatibility Compatibility issues with other mods label Mar 7, 2022
@Rakambda
Copy link
Member

Rakambda commented Mar 7, 2022

So both FallingTree and Origins modifies the breaking speed.

FallingTree: https://github.com/RakSrinaNa/FallingTree/blob/1.18.2/fabric/src/main/java/fr/raksrinana/fallingtree/fabric/mixin/AbstractBlockMixin.java#L20

Origins: https://github.com/apace100/apoli/blob/master/src/main/java/io/github/apace100/apoli/mixin/AbstractBlockMixin.java#L25

Now both of those methods takes the previously returned value into account, so it should be fine. Unless Origins has one of the powers that overrides it and returns a fixed value. I don't know Origins enough to be able to tell that though. Seems like it's controlled by this power and may be defined in json files.

@Dr-WeiAL
Copy link
Author

Dr-WeiAL commented Mar 7, 2022

I also don't understand very well, I didn't choose any race, this problem also occurs when using the default human

@stale
Copy link

stale bot commented Jul 10, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@Dr-WeiAL
Copy link
Author

If I remember correctly, the issue has been fixed

@Dr-WeiAL
Copy link
Author

Well, when I used fabric again, I found it didn't solve

@stale
Copy link

stale bot commented Jul 31, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙏keep open modloader: Fabric type: 🐛 bug Something isn't working type: 🔄 mod compatibility Compatibility issues with other mods
Projects
None yet
Development

No branches or pull requests

2 participants