Usability and capsulation

[PatrikHlobil]

Hi Rafal,

what do you think about the following ideas?

1. If the script is called as main, we could show the user a prompt (using wxpython or tkinter) where he can select via a file dialogue, where the .net, .dmd or matrix files lie. This would be very user friendly. On the other hand, if imported as a module one can still use the functions as they are.
2. For me, it seems as if the visum_to_pandas.py file contains quite a lot of testing code. I think we should separate that purely to the test.py file. This encapsulation simplifies the reusability of the module in my opinion.
3. I also have a script that automatically reads in an attribute file to a DataFrame. It also contains functions to remove units and convert to datetime objects. It is attached
   VisumPy_add.zip
   One could also consider adding such functions to your package.

Best,

Patrik

[RafalKucharskiPK]

Hi Patrik,

my idea about this script to create a handy and useful solution for Visum users with minimum possible workload. I am definitely not going into any GUI. I wrote quite a number of add-ins for Visum which were basically never used :) there is not much market for this.
So now I changed the philosophy and do free helpers - libraries for visum users with basic programming skills.

1. So definitely point 1 is out of my scope - yet you are welcomed to push it this direction
2. Point 2 - it think you are right, feel free to adjust. yet the test_read() is somehow different from assert in test.py, first one is to show to the user that everything went ok and to point him to the next steps with a ready snippet. The second one is intended as a software quality test.
3. Feel free to include this script.

And the last thing - I would like the visum_to_pandas to be as light as possible and as useful as possible. If someone will use it he knows python and programming and visum - he does not need gui and too much helpers.

Fell free to branch and implement your code
Best
Rafal

[RafalKucharskiPK]

PS. Here https://github.com/RafalKucharskiPK/PTVVisum_Python_Snippets you have quite a number of GUI examples scattered around various python codes. While here is quite mature GUI if you want https://github.com/RafalKucharskiPK/OptimalCountLocator_PTVVisum_AddIn - feel free to use.