-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retain Transformer Definitions - gs_save() and gs_load() #373
Comments
Hi @mikejiang, how difficult would it be retain the transformer definitions when saving and loading the GatingSet? This is the last remaining critical issue that I have for CytoExploreR. It is very common for users to export and reload their GatingSets to continue their analyses - but the lack of maintenance of the transformers is causing a number of issues for users. It seems that the issue originates from I have considered manually exporting linear data and associated transformers and then re-applying them upon import - but this seems very inefficient particularly when analysing large datasets (thousands of samples). It makes more sense to export and load the transformed data as is, but we need to preserve the transformers so that the data can still be returned to the linear scale when required. Do you have any suggestions on a viable workaround? I am out of ideas and considering writing the transformers to a Thanks for your help. |
Hi @mikejiang, I have done some digging around to track down where things are going wrong. Here is an example that will hopefully illustrate the problem. First we create a GatingSet and apply transformations to that GatingSet, we can see that the transformations are indeed attached and if we try to save and reload the GatingSet the transformations are retained.
If I extract a cytoset from the transformed GatingSet, reverse the transformations, add the cytoset to a new GatingSet and re-apply the transformations, the transformers are correctly attached to the new GatingSet. However, if I save and reload this new GatingSet, the transformers are no longer attached.
As you can see above, prior to exporting the GatingSet, the transformers are attached to the GatingSet, however after reloading the transformer definitions have been lost. Do you have any ideas why this is happening? It seems strange that the transformers are there just prior to saving but are lost after reloading. Thanks for your help! Dillon |
Hi @mikejiang,
I have noticed that the transformer definitions don't seem to be retained for GatingSets archived using
gs_save()
and reloaded withgs_load()
.Is there a way that we can keep the transformer definitions when saving the GatingSet?
The text was updated successfully, but these errors were encountered: