Fixed problem with -cout handling of input #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pxtl
reviewed
Mar 26, 2018
| @@ -22,7 +22,7 @@ static void Main(string[] args) | |||
| var inReader = options.ConsoleIn | |||
| ? Console.In | |||
| : new StreamReader(options.InputFile); | |||
| using (var outWriter = options.ConsoleIn | |||
| using (var outWriter = options.ConsoleOut | |||
There was a problem hiding this comment.
Hah, oops. Shows how I never tested this part.
Pxtl
reviewed
Mar 26, 2018
| @@ -84,8 +84,7 @@ public static string ToMarkDown(this XNode node, string assemblyName = null) | |||
|
|
|||
|
|
|||
| if (node.NodeType == XmlNodeType.Text) | |||
| return Regex.Replace(((XText)node).Value.Replace('\n', ' '), @"\s+", " "); | |||
|
|
|||
| return Regex.Replace(((XText)node).Value.Replace(@" ", ""), @"^\n|[S*|\n]$","",RegexOptions.Multiline); | |||
There was a problem hiding this comment.
Crud. I see your PR is based on the other PR. We'll have to resolve that first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #21