[Fix] Configure metrics compilation in root toml #3462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Subcrates would previously enable metrics by default instead of exposing them as a feature.
niklaslong
commented
Jan 6, 2025
| @@ -56,7 +56,7 @@ name = "snarkos" | |||
| path = "snarkos/main.rs" | |||
|
|
|||
| [features] | |||
| metrics = [ "snarkos-node-metrics", "snarkos-node/metrics" ] | |||
| default = [ "snarkos-node-metrics", "snarkos-node/metrics", "snarkos-cli/metrics" ] | |||
There was a problem hiding this comment.
Adding snarkos-cli/metrics here isn't strictly necessary for the feature to be compiled in (as they are additive across shared dependencies) but it is more complete.
vicsn
approved these changes
Jan 7, 2025
|
Done, sanity check sample output from the devnet prometheus metrics: |
niklaslong
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
clicrate currently enables metrics as a default feature, this PR moves the feature's configuration to the root level toml, enables it by default and introduces ametricsfeature oncli. In addition,snarks-node-metricsis made optional.Correct configuration can be verified with a reverse-search for the metrics crate by feature:
cargo tree -e features -i snarkos-node-metrics(which should show matches, metrics being enabled by default)cargo tree -e features -i snarkos-node-metrics --no-default-features(which should show no matches)Fixes #3379.
The last commit realigns the dependencies in the tcp crate, lmk if I should drop it or move it someplace else.
Edit: prometheus metric sanity check was also successful with a small devnet.