Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuthenticodeCheck should warn/error on non-Windows #1754

Open
3 tasks done
ThomasNieto opened this issue Nov 14, 2024 · 1 comment
Open
3 tasks done

AuthenticodeCheck should warn/error on non-Windows #1754

ThomasNieto opened this issue Nov 14, 2024 · 1 comment

Comments

@ThomasNieto
Copy link
Contributor

Prerequisites

  • Write a descriptive title.
  • Make sure you are able to repro it on the latest released version
  • Search the existing issues.

Steps to reproduce

If you use AuthenticodeCheck parameter on non-Windows it silently passes instead of writing a message to the user that signatures wasn't actually checked.

// Because authenticode and catalog verifications are only applicable on Windows, we allow all packages by default to be installed on unix systems.
if (!RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
{
return true;
}

Expected behavior

Write warning/error that parameter isn't supported on non-Windows.

Actual behavior

Nothing

Error details

No response

Environment data

n/a

Visuals

No response

@SydneyhSmith
Copy link
Collaborator

A warning seems appropriate here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants