Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When running tests using gcc, test-State.cpp reports 12 assertions less. #75

Closed
Possseidon opened this issue Feb 24, 2022 · 1 comment · May be fixed by #64
Closed

When running tests using gcc, test-State.cpp reports 12 assertions less. #75

Possseidon opened this issue Feb 24, 2022 · 1 comment · May be fixed by #64
Assignees
@Possseidon
Labels
invalid This doesn't seem right

Comments

@Possseidon
Copy link
Owner

Related to #64. When running test-State.cpp tests with WSL gcc, catch2 reports 12 assertions less than when using Windows msvc or clang.

Find out why.

An easy way to check for discrepancies would be to run both tests with verbose output and compare those.
@Possseidon Possseidon added the bug Something isn't working label Feb 24, 2022
@Possseidon Possseidon self-assigned this Feb 24, 2022
@Possseidon Possseidon linked a pull request Feb 24, 2022 that will close this issue
Add tests for dang-lua Convert and State. #64
Draft
@Possseidon
Copy link
Owner Author

The cause for this is Lua State can be constructed and closed. which creates and destroys Lua states with a checked allocator. These allocations differ between Windows and Linux.

The main reason is likely, that it even loads them with the Lua standard libraries, which are quite different between the two operating systems. It's almost surprising, that there are only 12 allocations less.

@Possseidon Possseidon added invalid This doesn't seem right and removed bug Something isn't working labels Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Possseidon Possseidon

Labels
invalid This doesn't seem right
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add tests for dang-lua Convert and State. Possseidon/dang-lib
1 participant
@Possseidon