From cfbfaf6b4452f55135917f637ede746cd18c7bd6 Mon Sep 17 00:00:00 2001
From: Peter Burns <rictic@google.com>
Date: Fri, 15 Apr 2016 16:58:25 -0700
Subject: [PATCH] Make noAnimations imply noink on the inner paper-ripple.

Fixes #102 where animation-free dropdowns ended up
with tons of Ripple objects endlessly and invisibly animating in
requestAnimationFrames, though I'll admit it's not a principled fix,
in that I'm not sure what the root cause of the bug is.

This seems to be roughly in line with user expectations I think, as
someone who doesn't want animations probably also doesn't want a
ripple animation.

I went this route rather than making `noink` work because the noink
property isn't mapped anywhere, and the requestAnimationFrame leak
would still occur for people using noAnimations.
---
 demo/index.html          | 2 +-
 paper-dropdown-menu.html | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/demo/index.html b/demo/index.html
index 4bb258e..9acd3af 100644
--- a/demo/index.html
+++ b/demo/index.html
@@ -178,7 +178,7 @@ <h4>A paper-dropdown-menu can contain any kind of content, such as tabs</h4>
     <h4>You can remove the ripple and the animations</h4>
     <demo-snippet class="centered-demo">
       <template>
-        <paper-dropdown-menu label="Dinosaurs" noink no-animations>
+        <paper-dropdown-menu label="Dinosaurs" no-animations>
           <paper-listbox class="dropdown-content">
             <paper-item>allosaurus</paper-item>
             <paper-item>brontosaurus</paper-item>
diff --git a/paper-dropdown-menu.html b/paper-dropdown-menu.html
index d3c5c67..fba635d 100644
--- a/paper-dropdown-menu.html
+++ b/paper-dropdown-menu.html
@@ -97,7 +97,7 @@
       on-iron-deselect="_onIronDeselect"
       opened="{{opened}}">
       <div class="dropdown-trigger">
-        <paper-ripple></paper-ripple>
+        <paper-ripple noink="[[noAnimations]]"></paper-ripple>
         <!-- paper-input has type="text" for a11y, do not remove -->
         <paper-input
           type="text"