Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paper-ripple sets transform every frame instead of using accelerated animation #3219

Closed
danakj opened this issue Dec 18, 2015 · 1 comment
Closed

Comments

@danakj
Copy link

danakj commented Dec 18, 2015

Rather than setting a new scale every frame, the effect would achieve better performance across browsers by using an accelerated animation. This would provide the browser with more hints to avoid re-raster on every frame.

The bug occurs in the drawRipple method https://code.google.com/p/chromium/codesearch#chromium/src/third_party/catapult/third_party/polymer/components/paper-ripple/paper-ripple.html&l=190

It can be reproduced by paper-button/demo.html, which is run by telemetry bots as per https://code.google.com/p/chromium/issues/detail?id=563504#c16

See more details here: https://code.google.com/p/chromium/issues/detail?id=563504#c18

@ebidel
Copy link
Contributor

ebidel commented Jan 3, 2016

This issue was moved to PolymerElements/paper-ripple#67

@ebidel ebidel closed this as completed Jan 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants