Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Lets clean up the docs! #116

Open
5 of 7 tasks
isabellabrookes opened this issue Apr 30, 2020 · 8 comments
Open
5 of 7 tasks

[Documentation] Lets clean up the docs! #116

isabellabrookes opened this issue Apr 30, 2020 · 8 comments
Assignees
Labels
📝documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed 👍👎YAYA NANA Community Vote!
Milestone

Comments

@isabellabrookes
Copy link
Collaborator

isabellabrookes commented Apr 30, 2020

This is a multiparter and a nice way to get your name on some open source ❤️.

Readme.md needs a little extra love:

Any suggestions/contributions welcomed!
Comment, upvote, contribute, engage. 🖤

@isabellabrookes isabellabrookes added 📝documentation Improvements or additions to documentation help wanted Extra attention is needed good first issue Good for newcomers 👍👎YAYA NANA Community Vote! labels Apr 30, 2020
@isabellabrookes isabellabrookes added this to the Documentation milestone Apr 30, 2020
isabellabrookes added a commit that referenced this issue Apr 30, 2020
#117)

* Update issue templates

* Update issue templates

Resolves #102.

* Created a new CONTRIBUTING.md

Create the start of a the new CONTRIBUTING.md as mentioned in #116

* Resolved Conflicts and updated Contributing list

* Updated missing links to go to correct page and section.

Co-authored-by: Isabella Brookes <[email protected]>
isabellabrookes added a commit that referenced this issue Apr 30, 2020
* 📝 Creating the start of a the new CONTRIBUTING.md as mentioned in #116 (#117)

* Update issue templates

* Update issue templates

Resolves #102.

* Created a new CONTRIBUTING.md

Create the start of a the new CONTRIBUTING.md as mentioned in #116

* Resolved Conflicts and updated Contributing list

* Updated missing links to go to correct page and section.

Co-authored-by: Isabella Brookes <[email protected]>

* 📝 updating a link in README.md

Co-authored-by: Matthew Peck-Deloughry <[email protected]>
@maxemiliang
Copy link

I would like to add that instructions for setting up firebase would be really nice, kinda like this repo or something similar: https://github.com/janoodleFTW/timy-messenger

@ggoodwin
Copy link

ggoodwin commented May 6, 2020

If pod install throws this error

env: node: No such file or directory

[!] Invalid `Podfile` file: A JSON text must at least contain two octets!.

This may indicate your CocoaPods is out of date.

Running sudo gem install cocoapods should update you to the latest version even if an older version is installed.

@adilanchian
Copy link
Collaborator

I have started doing the .env file work !

@isabellabrookes
Copy link
Collaborator Author

If pod install throws this error

env: node: No such file or directory

[!] Invalid `Podfile` file: A JSON text must at least contain two octets!.

This may indicate your CocoaPods is out of date.

Running sudo gem install cocoapods should update you to the latest version even if an older version is installed.

I think this should be added to a "troubleshooting" portion of the guides.

@adilanchian
Copy link
Collaborator

Just checked of:

Add set up for .env file. (@adilanchian should provide a sanitized .env.local file for us 👍 )
Add setup for integrating gruveebackend repo

Still working through a couple things, but mainly I want to start adding videos of our progress in the proper branches and such:

Add videos of current Grüvee progress

@edburtnieks-archive
Copy link

edburtnieks-archive commented Jul 3, 2020

Hi!

Upon trying set up local development environment on Windows 10 machine I ran into few issues and decided to add some notes to documentation for anyone who has ran into similar issues.

The documentation and layout may need to be adjusted, because I only tried the setup on Windows 10 machine for Android development.

Added

  • Missing .env variables
    • FIREBASE_PROD_URI
    • ALGOLIA_PROD_INDEX_NAME
  • Note to switch to release-1.0 branch
  • Info about google-services.json file to android development setup
    • Related to Add info for setting up own dev firebase checklist item under this issue. Maybe it would be better to extract it to separate Firebase section. Let me know what would be better.
  • Start Android Emulator section
    • Related to Add setup for running Android emulator checklist item under this issue. This is a very quick and dirty Android emulator setup. I haven't got any extensive experience with Android Studio and emulators, but for what I could figure out, was enough. Let me know if it should be more detailed or improved.
  • Note about android-start error on Windows 10

Pull request with changes: #142

@adilanchian
Copy link
Collaborator

@edburtnieks MUCH appreciated again. I just submitted some feedback for you here. Please let me know if it makes sense or you think certain sections should not be changed!

@adilanchian
Copy link
Collaborator

@isabellabrookes assigning this to you since you are writing some fancy scripts! Let's link this issue to it for PR review and such :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📝documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed 👍👎YAYA NANA Community Vote!
Projects
None yet
Development

No branches or pull requests

5 participants