-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to latest piston-graphics #111
Comments
I had a go at this (but not the sRGB conversion): https://github.com/gaborigloi/glium_graphics/tree/latest-graphics, this compiles with the latest piston2d-graphics. I noticed two things:
Also, I'm not sure what formatting to use, I'm still new to Rust. Should I just run rustfmt to format the code, or is the current formatting ok? |
Opened a pull request: #112 |
I think piston-graphics used the alpha equation from Gfx, but after doing some research it seems neither Glium or Gfx use the correct one. Opened PistonDevelopers/graphics#1042 |
For now, we could use |
Closes PistonDevelopers#111 - Bumped to 0.21.0 - Updated dependencies - Fix sRGB to linear conversion - Use `SrgbTexture2d`
The draw state has been simplified, which requires a different mapping to Glium draw state.
Convert from sRGB to linear color space.
The text was updated successfully, but these errors were encountered: