Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests for Becker & Hickl functions #47

Open
tritemio opened this issue Jun 11, 2019 · 0 comments
Open

Improve tests for Becker & Hickl functions #47

tritemio opened this issue Jun 11, 2019 · 0 comments
Labels
enhancement first-contribution-friendly Issues reasonably easy to tackle for first-time contributors. good-first-issue help wanted

Comments

@tritemio
Copy link
Contributor

As mentioned in #46, it would be nice to improve tests for the functions for loading Becker&Hikl files. The tests are in test_bhreader.py.

This can be a relatively easy task for a new contributor and would make reading BH files more robust in the long term.

PR adding one or more tests are very welcome and will be merged.


Technical description:
Right now there is a single test in nose format. It would be nice to convert this test to the simpler pytest format for consistency with test_pqreader.py (which can be used as an example).

Also, a simple smoke test for bh_print_sys_params() (and other functions) would be useful to avoid future breakage.

@tritemio tritemio added enhancement help wanted first-contribution-friendly Issues reasonably easy to tackle for first-time contributors. labels Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement first-contribution-friendly Issues reasonably easy to tackle for first-time contributors. good-first-issue help wanted
Projects
None yet
Development

No branches or pull requests

1 participant