Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text color on small and .small #328

Open
stephanandersen opened this issue Apr 16, 2019 · 2 comments
Open

Text color on small and .small #328

stephanandersen opened this issue Apr 16, 2019 · 2 comments

Comments

@stephanandersen
Copy link

We have this rule that includes a color for the generic tag small and its helper-class .small

.small, small {
    color: #6d6e71;
    font-size: 80%;
    font-weight: 400;
}

I believe it was added to mute small text in headings
<h1>Customer Name <small>(#customer-number)</small></h1>

I like that behavior in headings actually, even though we got text-muted, but the generic small rule looks just wrong to me

@Akswii
Copy link
Contributor

Akswii commented May 20, 2019

We are not completely sure what your issue is, can you clarify?

Is your issue with small in plain text?
Is your issue that the text is faded?

@stepandersen
Copy link

We have this rule that includes a color...

My issue is that a color is specified on a generic tag, in this case small.
It means that <p class="text-success">I'm green and <small>I'm gray</small>.</p>.
There is an easy workaround, <p class="text-success">I'm green and <small class="text-success">I'm green</small>.</p>, but I would expect small to inherit if I set color on a parent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants