Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BANE grid option help string #212

Open
tjgalvin opened this issue May 6, 2024 · 1 comment
Open

BANE grid option help string #212

tjgalvin opened this issue May 6, 2024 · 1 comment
Assignees
Labels
BANE fixed in dev Issue has been fixed in the development (dev) branch.

Comments

@tjgalvin
Copy link
Contributor

tjgalvin commented May 6, 2024

Maybe it was just me but I got a little confused by the help string for the --grid option in BANE. My first reading made it seem like it was specified in units of the synthesised beam. Reading the code though it is clear that it is expected in units of pixels, and of left unset something is derived using the restoring beam encoded in the fits header.

It might be good to add an explicit in units of pixels in the help string. it only became clear to me when i went reading through the code.

It would be nice to have an optional flag asking BANE to treat these user provided numbers in units of the restoring beam instead of pixels. I think most of the infrastructure to support this is already in place.

@PaulHancock PaulHancock self-assigned this Dec 9, 2024
PaulHancock added a commit that referenced this issue Dec 9, 2024
@PaulHancock PaulHancock added BANE fixed in dev Issue has been fixed in the development (dev) branch. labels Dec 9, 2024
@PaulHancock
Copy link
Owner

Good point. I've updated the text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BANE fixed in dev Issue has been fixed in the development (dev) branch.
Projects
None yet
Development

No branches or pull requests

2 participants