Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor comments tree build functions / Рефакторинг функций построения дерева комментариев #635

Open
kabalin opened this issue Nov 26, 2023 · 2 comments
Open

Refactor comments tree build functions / Рефакторинг функций построения дерева комментариев #635

kabalin opened this issue Nov 26, 2023 · 2 comments
Assignees
@PedramHaeri
Labels
backend Comments All issues related with a user comments good first issue All tasks for good start by new contributors Improvement

Comments

@kabalin
Copy link
Member

kabalin commented Nov 26, 2023

It looks like there is lot of duplication between controller functions for building comments tree for anonymous, authenticated user and moderator. They need to be refactored following DRY principles and tests added.
@kabalin kabalin added Comments All issues related with a user comments good first issue All tasks for good start by new contributors backend Improvement labels Nov 26, 2023
@kabalin kabalin mentioned this issue Nov 26, 2023
Merged
@PedramHaeri
Copy link

Hi I would like to try and fix this issue. could you please assign it to me?

@kabalin
Copy link
Member Author

kabalin commented Nov 27, 2023

Hello Pedram, thanks, feel free to create draft PR and ask any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PedramHaeri PedramHaeri

Labels
backend Comments All issues related with a user comments good first issue All tasks for good start by new contributors Improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kabalin @PedramHaeri