From 1c1e47f28c285d253ec4c38cb7bba518708d1a6c Mon Sep 17 00:00:00 2001 From: Ben Clifford Date: Tue, 2 Jul 2024 13:50:08 +0000 Subject: [PATCH] Join on stopped thread at end of LocalProvider+ssh test This stops that thread being left still running over the end of the test - which is needed in work in PR #3397 to ensure that no threads are left running at the end of a test. If that shutdown hangs, this test will now hang rather than leave the thread behind. Along with PR #3504, this eliminates any threads left behind after parsl/tests/test_providers/test_local_provider.py --- parsl/tests/test_providers/test_local_provider.py | 1 + 1 file changed, 1 insertion(+) diff --git a/parsl/tests/test_providers/test_local_provider.py b/parsl/tests/test_providers/test_local_provider.py index 29907ec47d..06b18c0ee9 100644 --- a/parsl/tests/test_providers/test_local_provider.py +++ b/parsl/tests/test_providers/test_local_provider.py @@ -105,6 +105,7 @@ def test_ssh_channel(): def _stop_sshd(sshd_thread): sshd_thread.stop() + sshd_thread.join() class SSHDThread(threading.Thread):