Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup mock servers & fix demo #20

Closed
2 tasks done
warpech opened this issue May 30, 2016 · 5 comments
Closed
2 tasks done

Cleanup mock servers & fix demo #20

warpech opened this issue May 30, 2016 · 5 comments
Assignees

Comments

@warpech
Copy link
Contributor

warpech commented May 30, 2016

After #16 there are some problems:

  • instances of jasmine-core and jasmine-ajax still loaded in the test helper, but (probably?) not used anymore
  • demo/index.html seems to not work anymore (seen on @aloscha's screen)
joozek78 added a commit that referenced this issue May 30, 2016
Fix demo and remove unused imports. Closes #20
@joozek78
Copy link
Contributor

Live Demo still fails due to dependencies fail

@joozek78
Copy link
Contributor

It turned out that iron-component-page is broken. It detects if it's served from gh-pages and if so, it uses cdn.rawgit.com to fetch element to present. It has two problems:

  1. cdn.rawgit.com is case-sensitive and our org name (PuppetJs) contains uppercase characters. Iron-component-page never works in such case (see code)
  2. cdn.rawgit.com caches permanently, but iron-component-page always refers to master, so it quickly grows stale
  3. iron-component-page refers to master, but we use gh-pages as main branch

I changed the link in the readme to point directly to demo (which works fine) to avoid iron-component-page

@warpech
Copy link
Contributor Author

warpech commented Jun 24, 2016

@joozek78 could you please write an issue in https://github.com/PolymerElements/iron-component-page about this?

So we play nice with the ecosystem, not just abandon ship because it has a bug.

@warpech warpech reopened this Jun 24, 2016
@joozek78
Copy link
Contributor

@warpech It seems that there are already 2 issues posted there, both ignored by the team: PolymerElements/iron-component-page#44 and PolymerElements/iron-component-page#101. @tomalec even submitted a PR for the second one, but it hasn't been addressed by the team either. I don't see what I could do there beside "liking" the issues :(

@warpech
Copy link
Contributor Author

warpech commented Jun 28, 2016

I see. Then we we did all we can. Thanks!

@warpech warpech closed this as completed Jun 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants