Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MemoryAdapter] Support nested Fields in Condition filters #60

Open
5 tasks
alexander-schranz opened this issue Jan 8, 2023 · 0 comments
Open
5 tasks
Labels
Adapter: Memory Memory Adapter related issue features New feature or request good first issue Good for newcomers

Comments

@alexander-schranz
Copy link
Member

alexander-schranz commented Jan 8, 2023

Currently the Memory Adapter does not support Condition on nested fields.

https://github.com/schranz-search/schranz-search/blob/d8a3567634d534babe9ee64af638194b5f486fef/packages/seal-memory-adapter/MemoryConnection.php#L78-L80

A test should be added for nested filter and the MemoryAdapter / MemoryConnection should be adopted to support this also.

  • Support Nested Fields in:
    • EqualCondition
    • NotEqualCondition
    • ...
  • Add abstract TestCase
@alexander-schranz alexander-schranz added features New feature or request Adapter: Memory Memory Adapter related issue labels Jan 8, 2023
@alexander-schranz alexander-schranz changed the title [MemoryAdapter] Support Condition on nested Fields [MemoryAdapter] Support nested Fields in Condition filters Jan 8, 2023
@alexander-schranz alexander-schranz added the good first issue Good for newcomers label Jan 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Adapter: Memory Memory Adapter related issue features New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant