Skip to content

Latest commit

 

History

History
105 lines (77 loc) · 5.29 KB

README.md

File metadata and controls

105 lines (77 loc) · 5.29 KB
description
This document is under development. You are welcome to share your thoughts.

Development Notes BOS

Issues Notes From April 2020

  1. Participants None to be managed propmptly, Catch this exception and manage properly
CRITICAL | Uncaught exception: 'NoneType' object is not iterable

Traceback (most recent call last):
  File "/home/ubuntu/jemshid/bos-auto/bookied/triggers/create.py", line 88, in getIncidentEvent
    return self.getEvent()
  File "/home/ubuntu/jemshid/bos-auto/bookied/triggers/trigger.py", line 104, in getEvent
    raise exceptions.EventDoesNotExistException
bookied.exceptions.EventDoesNotExistException

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/home/ubuntu/jemshid/bos-auto/bookied/work.py", line 145, in process
    trigger.trigger(args)
  File "/home/ubuntu/jemshid/bos-auto/bookied/triggers/trigger.py", line 115, in trigger
    self._trigger(*args, **kwargs)
  File "/home/ubuntu/jemshid/bos-auto/bookied/triggers/create.py", line 19, in _trigger
    self.event = self.getIncidentEvent()
  File "/home/ubuntu/jemshid/bos-auto/bookied/triggers/create.py", line 97, in getIncidentEvent
    return self.createEvent()
  File "/home/ubuntu/jemshid/bos-auto/bookied/triggers/create.py", line 112, in createEvent
    sport_identifier=self.sport.identifier,
  File "/home/ubuntu/jemshid/bos-auto/env/lib/python3.6/site-packages/bookied_sync/event.py", line 98, in __init__
    if not self.test_teams_valid():
  File "/home/ubuntu/jemshid/bos-auto/env/lib/python3.6/site-packages/bookied_sync/event.py", line 105, in test_teams_valid
    return all(self.participants.is_participant(t) for t in self["teams"])
  File "/home/ubuntu/jemshid/bos-auto/env/lib/python3.6/site-packages/bookied_sync/event.py", line 105, in <genexpr>
    return all(self.participants.is_participant(t) for t in self["teams"])
  File "/home/ubuntu/jemshid/bos-auto/env/lib/python3.6/site-packages/bookied_sync/participant.py", line 29, in is_participant
    for team in parties:
TypeError: 'NoneType' object is not iterable

Issues

  1. JobTimeoutException when trying to approve proposals: Solved
    1. The issue is solved and details are given below under the heading BOS-AUTO#12
    2. This issue is already open in Github, issue #12, bos-auto and BOS-208 in JIRA
    3. The issue can be solved by making sure that no proposals are pending approval by the witness when the witness starts proposing or approving a new incident.
  2. BOS-AUTO takes about 12 minutes to propose soccer events: Solved
    1. Soccer has 8 betting market groups
    2. And with TEST and BTF coins, it (soccer) has 34 betting markets.
    3. The time taken for betting market increases with each created betting market in a proposal. For example it takes 1 second for creating the first betting market, where as it takes about 30 seconds for creating the 34th betting market.
  3. None type object is not iterable, error:
    1. Details to be reproduced and added.
    2. This is a bos-sync issue.
  4. There is a cache error, occurring at times.
  5. Through out a proposal creating the CPU usage is 100%. : Discarded

Root cause exploration

  1. The present code doesn't ensure that approval is called after making a proposal.
  2. bookied_sync/lookup.py, def update() is the method where the time bottleneck is. The reason for time taken is it takes time to look up for items in chain and buffers.
  3. bookied_sync/bettingmarket.py, def propose_new(). This method has a reference to a class variable. Any reference to this variable takes significant time per betting market and time taken per betting market increases as number of betting market increases.
  4. bookied_sync/bettingmarket.py, def find_id() method has self.parent.get_id. This in turn calls lookupy, def get_id() and which inturn sport.py, def find_id(). A recursive call is found at this level and the recursion makes multiple calls to the chain continuously. This is a major location for making the code efficient.

Possible solutions

  1. Ensure that approval is called before and after an event proposal
  2. How about increasing timeout to 12 minutes?

Notes on completed development tasks

  1. graphenecommon/blockchainobject.py, line 175, getfromcache error, investiagate:
    1. The issue is found to be not repeating when all libraries are new version.
  2. Running a two core machine looks better.
  3. Solved BOS-AUTO #12, #16, #17 which are timout and time taken more than 180 seconds, yaml.load deprecation, and q.dequeue error.

BOS analysis

  1. Experimental setup: Need 3 machines
  2. Analyse data on the blocks.
  3. Look at settled bets on the block
  4. Meeting in with Paul, Pravin and Bob in the last week of March or first week of April 2020.

BOS-AUTO #12 and Reducing time taken per proposal

There is a for loop in method createBmgs in bookied/triggers/create.py

Check time taken for each BMG creation and exit createBmg for loop and trigger if time exceeds, say 10 seconds.

Upon exiting createBmgs, set_incident_status to "midway"

In scheduler, bookied/scheduler.py, check for "midway" events and add them to rq queue for work.process.

add approval prior and after each work.process and ensure they are called in order with depends_on argument of rq.

Trigger the flask server with --scheduler option

It works!