Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

album art doesnt have correct aspect ratio #319

Open
ChorusCory opened this issue Dec 6, 2024 · 3 comments
Open

album art doesnt have correct aspect ratio #319

ChorusCory opened this issue Dec 6, 2024 · 3 comments

Comments

@ChorusCory
Copy link

exactly what it sounds like, album art not in a 1:1 ratio is stretched. any way to correct this
image

@ChorusCory
Copy link
Author

here's what they should look like btw
EarthBound
cover

@JadeTank
Copy link
Collaborator

JadeTank commented Dec 6, 2024

This is intended behavior, anything that doesn't have a square aspect ratio will be resized to fit in the image grid. Implementing a non-standard aspect ratio would introduce a lot of issues with the layout across all the different panels. It's just too much of an edge case for how much it would take to implement and likely won't be added, at least not by me.

Edit: Actually I guess you could potentially get around needing to worry about layout by just padding the top and bottom of the image. Will try and look into it.

@ARDEACT
Copy link

ARDEACT commented Dec 28, 2024

This is intended behavior, anything that doesn't have a square aspect ratio will be resized to fit in the image grid. Implementing a non-standard aspect ratio would introduce a lot of issues with the layout across all the different panels. It's just too much of an edge case for how much it would take to implement and likely won't be added, at least not by me.

Edit: Actually I guess you could potentially get around needing to worry about layout by just padding the top and bottom of the image. Will try and look into it.
image
Is it possible for you to implement correct aspect ratios for this album cover preview? It's not on a grid so I suppose it should be easier to implement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants