Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MigrationValidator Actor/Service #21

Open
revgum opened this issue Dec 18, 2018 · 3 comments
Open

MigrationValidator Actor/Service #21

revgum opened this issue Dec 18, 2018 · 3 comments

Comments

@revgum
Copy link
Contributor

revgum commented Dec 18, 2018

Periodically, (maybe a background job running a daily rake task?) check all Work that has been published to OD2, but hasn't been validated.

  • Using Work type, query for validations
    • Evaluate metadata existence on OD2
    • Evaluate attached files/children and metadata existence on OD2
  • If validations pass, then update the Work to mark it as validated
@revgum
Copy link
Contributor Author

revgum commented Dec 19, 2018

see #23

@revgum revgum added bug Something isn't working Migration and removed Migration bug Something isn't working labels Jan 14, 2019
@revgum revgum changed the title migration validation after save MigrationValidator Actor/Service Feb 22, 2019
@lsat12357
Copy link
Contributor

lsat12357 commented Jun 20, 2019

can we break this into maybe two pairs of actor/service? one to check the metadata and one to check files. maybe more if there are other things to break out and check. relationships?

@lsat12357
Copy link
Contributor

This is mostly done. At the moment, the VerifyWorkService records the output of each verifier service in the migrator work, but there is no var in the work that shows this status. If the output is empty of errors, it would easy to add a Verified: success/errored to the migrator work env. The batch reporter in verification mode checks for the errors, it could be modified to also report this status.
Based on what happened with OD1 migration, we may get to the point where we choose to ignore some problems, and save fixes for cleanup activity; in that case, what would the status be, and how would it be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants