New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve file upload security and error handling in ovos-support script #131

Open

coderabbitai bot opened this issue Jan 18, 2025 · 0 comments

Assignees

coderabbitai bot commented Jan 18, 2025

Security improvements needed for the file upload functionality in ovos-support script:

Add user confirmation prompt before upload to allow inspection of potentially sensitive data
Add proper verification of upload success by checking HTTP status code
Add error handling for curl failures and network issues
Extract response body and status code separately for better error reporting

Related PR: #129
Related comment: #129 (comment)

coderabbitai bot assigned JarbasAl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment