Skip to content
This repository has been archived by the owner on Sep 22, 2019. It is now read-only.

add synth_id to response from synth-dependent services #230

Open
arlin opened this issue Dec 21, 2016 · 4 comments
Open

add synth_id to response from synth-dependent services #230

arlin opened this issue Dec 21, 2016 · 4 comments

Comments

@arlin
Copy link

arlin commented Dec 21, 2016

Clients or users who employ subtree and induced_subtree may wish to have the synth tree version. This would be useful for the phylotastic project.

Add synth_id to response from subtree, induced_subtree, and any other services that return results dependent on the synth tree.

@josephwb
Copy link
Member

josephwb commented Dec 21, 2016

This was implemented but was voted down. Fortunately most things were just commented out, so easy to do.

@josephwb
Copy link
Member

E.g. this.

@jar398
Copy link
Member

jar398 commented Dec 21, 2016 via email

@josephwb
Copy link
Member

I gather that there will be a drawn-out discussion on the best way forward by people who understand the best practices. For me, how versions are assigned is something that needs thought, and I would argue for consistency (but that isn't always seen as necessary). But reporting existing version numbers in query responses seems very straightforward. This is extremely relevant information (as is the taxonomy version), and I cannot fathom why would ever not provide it. We could satisfy @arlin's request immediately by reversing these commits:

4586db3
4c69297
0a33ce1
177c157

Please note: I only put this here for easy reference for the issue at hand. I know I didn't understand the issues last time around, and am not looking to be told how wrong I am. Whatever solution is best is best.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants