Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wikibase : New media upload support for validation of mandatory properties #7068

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Wikibase : New media upload support for validation of mandatory properties #7068

wants to merge 8 commits into from

Conversation

sunilnatraj
Copy link
Contributor

@sunilnatraj sunilnatraj commented Jan 7, 2025 •
edited
Loading

Fixes #95

Changes proposed in this pull request:

  • Support to define mandatory properties in New media upload
  • Raise warnings if any of the mandatory properties is not set
  • Updated manifest schema to validate new entries for the newly added mandatory properties list
  • Updated Warning to not set example entity for new media case as the label resolver fails for non-existent entity
Screenshot 2025-01-07 at 2 41 10 PM

@sunilnatraj
Issue 95 - Validate new media entry before upload
7e71d4f 
Added support to define
- New media constraints in manifest
- Updated NewEntityScrutinizer to validate new media if constraints are defined, log Warnings for all violations
@sunilnatraj
Merge remote-tracking branch 'upstream/master' into issue-95
26b382c
@sunilnatraj
New media upload validation
06ea0df 
- Added support to define mandatory properties in manifest
- Update NewEntityScrutinizer to honor defined mandatory new media property definition
- Updated manifest template to ensure manifest validation
- Updated unit test
@sunilnatraj
Lang file fix
cd4a017
@sunilnatraj
Lint fix
054ddd8
@sunilnatraj
Removed example reference for new media warning
d3a59d0 
Warning generation fails as it is unable to resolve entity set in the warning as entity has not been created yet.
@sunilnatraj sunilnatraj requested a review from wetneb January 7, 2025 09:14
@github-actions github-actions bot added Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements. Priority: Low Indicates less critical issues that can be dealt with at a later stage Theme: UX/Usability Focuses on issues related to improving the overall user experience and interaction flow. logic Changes to the data model, to the way operations, expressions work Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. labels Jan 7, 2025
@sunilnatraj
Copy link
Contributor Author

@wetneb Can you review PR to update the manifest used in tests. https://github.com/OpenRefine/wikibase-manifests/pull/14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wetneb wetneb Awaiting requested review from wetneb

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
logic Changes to the data model, to the way operations, expressions work Module: Frontend These issues involve working on HTML, CSS, and JavaScript code that affects the user interface. Priority: Low Indicates less critical issues that can be dealt with at a later stage Theme: UX/Usability Focuses on issues related to improving the overall user experience and interaction flow. Type: Feature Request Identifies requests for new features or enhancements. These involve proposing new improvements.
Projects
None yet
Milestone
No milestone
1 participant
@sunilnatraj