Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review the database schema #139

Closed
UlisesGascon opened this issue Dec 13, 2024 · 7 comments
Closed

Review the database schema #139

UlisesGascon opened this issue Dec 13, 2024 · 7 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed migrations technical-debt

Comments

@UlisesGascon
Copy link
Member

It seems like the relations between the tables might have room for improvement. We want to make sure that relation fields like github_organization.project_id are not NULLABLE.

Additionally, we should review the datatypes for the columns to ensure they are aligned with the content.

@UlisesGascon UlisesGascon added good first issue Good for newcomers help wanted Extra attention is needed migrations technical-debt labels Dec 13, 2024
@bjohansebas
Copy link
Contributor

i can help with this 😄

@UlisesGascon
Copy link
Member Author

I assigned this issue to you, let me know if you need help :)

@bjohansebas
Copy link
Contributor

bjohansebas commented Dec 17, 2024

We want to ensure that the IDs are numbers, or we could switch them to UUID?

@bjohansebas
Copy link
Contributor

bjohansebas commented Dec 17, 2024

Here I will write about the changes:

  • github_organizations: None, all match their type in the API.
  • github_repositories:
    • github_organization_id not null

@bjohansebas
Copy link
Contributor

According to my review, only one change to the schema would be needed. I can't do it myself until next year, maybe someone else would like to do it.

@bjohansebas bjohansebas removed their assignment Dec 18, 2024
@telekosmos
Copy link
Contributor

According to my review, only one change to the schema would be needed. I can't do it myself until next year, maybe someone else would like to do it.

For what I've seen and without knowing some aspects of the schema, agree 👍 , NOT NULL constraints didn't seem to be that bad.

@UlisesGascon
Copy link
Member Author

I think that with the changes in #160 and #167 we are good to go and we can close this issue, but we can re-open it again if we need more work on this again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed migrations technical-debt
Projects
None yet
Development

No branches or pull requests

3 participants