Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace jupyter token authentication with prepared hashed password #67

Open
morrieinmaas opened this issue Mar 2, 2021 · 0 comments
Open
Labels
Type: Improvement 📈 Performance improvement not introducing a new feature or requiring a major refactor

Comments

@morrieinmaas
Copy link
Collaborator

Description

Change the default token issuing by jupyter with a password as described in the jupyter docs in order to enable predictable links. This way Alice's notebook can be linked to Bob's properly and reliably and vice verse. This also renders running get_URLS.sh redundant, and hence improves simplicity.

Are you interested in working on this improvement yourself?

  • Yes, I am.
  • Happy for anyone else to pick it up

Additional Context

Currently, it is necessary to run ./scripts/get_URLS.sh from the root folder to access the notebooks. The URLs are different every time the jupyter server is started. This also makes it impossible to but links from to Bob's notebook in Alice's notebook and vice verse. With a set password this should be possible.

Considerations

Is this compromising any safety aspects? I currently don't think it does since this is meant as a playground to explore. If it does, please, comment on why. And maybe it is then possible to make this optional so that when starting this on local it uses the password and when run on a remote machine it doesn't. However, will the have much benefit then since the links will be broken when running on remote?

@morrieinmaas morrieinmaas added the Type: Improvement 📈 Performance improvement not introducing a new feature or requiring a major refactor label Mar 2, 2021
@morrieinmaas morrieinmaas changed the title Replace jupyetr token authentication with prepared hashed password Replace jupyter token authentication with prepared hashed password Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement 📈 Performance improvement not introducing a new feature or requiring a major refactor
Projects
None yet
Development

No branches or pull requests

1 participant