Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better Response from terminate() #65

Open
wip-abramson opened this issue Feb 23, 2021 · 2 comments
Open

Better Response from terminate() #65

wip-abramson opened this issue Feb 23, 2021 · 2 comments
Labels
Type: Improvement 📈 Performance improvement not introducing a new feature or requiring a major refactor

Comments

@wip-abramson
Copy link
Member

Description

Currently the .terminate() function returns None. This is not very useful, lets make it better. Probably a boolean? Not sure, open to ideas.
@wip-abramson wip-abramson added the Type: Improvement 📈 Performance improvement not introducing a new feature or requiring a major refactor label Feb 23, 2021
@frogman
Copy link

frogman commented Feb 24, 2021

Hi. Python returns none by default. Should we add 'return self' at the end and make use of it?

@wip-abramson
Copy link
Member Author

Yeah maybe self, I hadn't thought of that. We should definitely return something I feel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Improvement 📈 Performance improvement not introducing a new feature or requiring a major refactor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@frogman @wip-abramson