Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default values do not work when using multiple engine types #621

Open
jkirk5 opened this issue Dec 6, 2024 · 0 comments
Open

Default values do not work when using multiple engine types #621

jkirk5 opened this issue Dec 6, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@jkirk5
Copy link
Contributor

jkirk5 commented Dec 6, 2024

Description

Normally, if your Aviary model does not define a variable, the default value is used. In the case where your model using multiple engine types, and you do not specify a required variable that should be vectorized across engines (Aircraft.Engine.*, Aircraft.Nacelle.*), an error occurs. This happens because all set_input_defaults() is called on every variable in the metadata using metadata defaults, which neglects to add the vectorization needed for multiple engine types.

Example

This error can be seen when running test_bench_multiengine.py, which fails because Aircraft.Nacelle.LAMINAR_FLOW_UPPER and Aircraft.Nacelle.LAMINAR_FLOW_LOWER were not defined in the input data used

Aviary Version

latest

Relevant environment information

No response

@jkirk5 jkirk5 added the bug Something isn't working label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant