-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort cities by country? #96
Comments
Or maybe have expandable sections for each country? |
Sure, either works. @jameschildress what say you? |
I like the expandable sections by country option myself, but either is a good move in my opinion. So +1 |
I don't like the sound of the expanding menu because the bulk of the cities are in the US and will therefor require an extra click. I'd support a nested menu though. Same idea with no clicks. |
Thoughts...
What would a nested menu look like? Do you have a mockup? |
@anoldguy Just a really simple mockup here in the comments section, because either way the actual look of this is still to be determined. The countries are the top level sorted by number of cities inside or alphabetically. US
Canada
China
|
regarding point number 2 on ethnocentricity, I personally see nothing wrong with going either by number of openhacks per country or alphabetizing by country. Either way has a logical reason behind it and therefore no need for anyone to feel that some one's not on equal footing. It's just numbers and/or letters. |
So we can use this data structure in ---
countries:
USA:
- atlanta:
name: Atlanta, GA
- buffalo:
name: Atlanta, GA
Canada:
- waterloo:
name: Waterloo, ON
- toronto:
name: Toronto, ON Looping through it is dumb, but works:
|
Looks like a good 80/20, and fixes the issue we have. If you don't tackle it, I'll try to get to it tomorrow. |
Seems like this would be easier for organization of the sidebar.
_config.yml
to use new data structure_layouts/default.html
Rakefile
for cities to include country on input and on output into_config.yml
The text was updated successfully, but these errors were encountered: