Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(tlg062) duplicate editions #2750

Open
lcerrato opened this issue Jul 10, 2023 · 3 comments
Open

(tlg062) duplicate editions #2750

lcerrato opened this issue Jul 10, 2023 · 3 comments
Assignees
Labels
enhancement Special case requires special handling

Comments

@lcerrato
Copy link
Collaborator

Move unneeded duplicate editions (Harmon Loeb) to
https://github.com/OpenGreekAndLatin/First1KGreek/tree/master/save

tlg0062.tlg001.1st1K-grc1-tlg0062.tlg052.1st1K-grc1

Harvest notes or use for diff first?

@gregorycrane
Copy link
Contributor

Definitely harvest the notes -- which are very easy to use and can be extracted as a standoff commentary. That's because each note includes in it the lemma that it affects in the Greek -- the key thing is to make sure we can match that lemma up: e.g. a variant from volume 1. There will be DE errors in the notes but we can find most of them when we try to match lemma to source and when we try to tag the witnesses.

image

@lcerrato
Copy link
Collaborator Author

@gregorycrane
This sounds like a good student project to reinsert notes.
Moving the files out of the active repo has no bearing on this work, so they can be moved at any time.

@gregorycrane
Copy link
Contributor

I have harvested the notes from this version and added them to the Perseus Greek xml. I also added the Arcadia fund to the funders because we are using the notes that Arcadia paid for. When we add the new version of Harmon, we can retire the 1st1k version. I hope to submit a pull request for that today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Special case requires special handling
Projects
None yet
Development

No branches or pull requests

2 participants