Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for blank log lines #2914

Open
stuartc opened this issue Feb 7, 2025 · 0 comments · May be fixed by #2915
Open

Allow for blank log lines #2914

stuartc opened this issue Feb 7, 2025 · 0 comments · May be fixed by #2915
Assignees
@stuartc

Comments

@stuartc
Copy link
Member

stuartc commented Feb 7, 2025

Details

We currently don't allow blank log lines to be stored.

However a lot of people emit blank console.log() and should be able to see the logs like as if they were running the job locally.

User acceptance criteria

Blank log lines should be persisted, and this Elixir.LightningWeb.RunChannel.Error error should no longer be experienced in the RunChannel:

#Ecto.Changeset<action: :insert, changes: %{timestamp: ~U[2025-02-07 09:32:16.249492Z], run: #Ecto.Changeset<action: :update, changes: %{}, errors: [], data: #Lightning.Run<>, valid?: true, ...>, source: "ADA", step_id: "162e723f-0fee-4ec8-b40b-8994fb50168d", run_id: "1fe6ee9a-046a-4af9-9471-ae7b7013dbea"}, errors: [message: {"can't be blank", [validation: :required]}], data: #Lightning.Invocation.LogLine<>, valid?: false, ...>
@stuartc stuartc self-assigned this Feb 7, 2025
@stuartc stuartc added this to v2 Feb 7, 2025
@github-project-automation github-project-automation bot moved this to New Issues in v2 Feb 7, 2025
@stuartc stuartc moved this from New Issues to In progress in v2 Feb 7, 2025
stuartc added a commit that referenced this issue Feb 7, 2025
@stuartc
Refactor log message handling to allow nil values and improve error v…
b447651 
…alidation

```
console.log();          => new line
console.log('');        => new line
console.log(null);      => null
console.log(undefined); => new line
```

Closes #2914
@stuartc stuartc linked a pull request Feb 7, 2025 that will close this issue
Draft
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stuartc stuartc

Labels
None yet
Projects
v2
Status: In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow empty log lines to be sent from the worker OpenFn/lightning
1 participant
@stuartc