services: fix casting on toast #427
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonmicro
requested changes
Jan 12, 2025
simonmicro
force-pushed
the
feature/ble/basic-server
branch
from
55f1910 to
1590abd
Compare
RuffaloLavoisier
force-pushed
the
fix/toast
branch
from
7a22ca5 to
4706616
Compare
simonmicro
reviewed
Jan 12, 2025
| @@ -13,11 +13,12 @@ NotificationData OswServiceTaskNotifier::createNotification(std::chrono::time_po | |||
|
|
|||
| std::chrono::time_point<std::chrono::system_clock, std::chrono::seconds> getTimeToFire(int hours, int minutes) { | |||
| auto utcTime = std::chrono::system_clock::from_time_t(OswHal::getInstance()->getUTCTime()); | |||
| auto currentTime = utcTime + std::chrono::seconds{static_cast<int>(OswHal::getInstance()->getTimezoneOffsetPrimary())}; | |||
| auto utcTimeInSeconds = std::chrono::duration_cast<std::chrono::seconds>(utcTime.time_since_epoch()); | |||
| auto currentTime = utcTimeInSeconds + std::chrono::seconds{static_cast<int>(OswHal::getInstance()->getTimezoneOffsetPrimary())}; | |||
| auto currentDate = date::sys_days(floor<date::days>(currentTime)); | |||
| auto scheduledTime = std::chrono::hours{hours} + std::chrono::minutes{minutes} + std::chrono::seconds{0}; | |||
| auto timeToFire = currentDate + scheduledTime; | |||
There was a problem hiding this comment.
This is a duration, right? Why did you not cast here?
simonmicro
reviewed
Jan 12, 2025
| if (auto it = scheduler.begin(); | ||
| it != scheduler.end() && currentTime >= it->first) { | ||
| it != scheduler.end() && currentTime.count() >= it->first.time_since_epoch().count()) { |
simonmicro
force-pushed
the
develop
branch
2 times, most recently
from
890efcf to
9478a8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix time casting issue on toast feature.