-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Which SDK should we use? #37
Comments
Note: tried to run with UPDATE:
|
On the original issue: Wow yeah didn't even know about the other gem. If that's what we should be installing, that's what the docs should say... About the require: Bundler will auto-require the lib, if there's a file with a name matching the name of the gem. In the case of |
@bmulholland thanks for the hint! About the other gem: i can confirm that solved #30 (and i guess it also solve all the others as well) |
I was about to adopt onesignal_sdk myself, but paused: it's not published by someone clearly attached to OneSignal on RubyGems. Neither is the original, for that matter. How do we know one or both of them is under control of OneSignal? Could one of them be a supply chain attack? Was the new gem published because OneSignal has lost control of the old gem? If so, that speaks to real concerns about who may have control to them, and what may be published there. There's substantial security issues here. Ironically, installing directly from Github may actually be the safest installation method for now. |
@bmulholland @edolix Thanks for reporting!
Depending on what APIs you need to integrate with you may want to use the OneSignal ruby gem |
Closing this issue as the original question is answered. All other issues regarding gem releases and missing features will be tracked in their respective tickets. |
How can we help?
Hey there!
I think there are other kind-of related issues like: #31 #34 #30 #20 #12
Looks like on rubygems there are two different SDKs:
onesignal_sdk
matchesOneSignal::VERSION
(2.0.2) but in the installation instructions you mentionedonesignal
that is still on1.0.1
.onesignal-ruby-api/lib/onesignal/version.rb
Lines 13 to 15 in 6a970c4
The repo is missing the git tag for 2.0.2 so there's a bit of confusion on which SDK should be used.
Thanks!
Code of Conduct
The text was updated successfully, but these errors were encountered: