Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto add Notification Service Extension #688

Closed
wants to merge 8 commits into from
Closed

Auto add Notification Service Extension #688

wants to merge 8 commits into from

Conversation

ludufre
Copy link

@ludufre ludufre commented Jan 31, 2021

Hi, I made a hook to auto add Notification Service Extension and App Group. I tested with 5 projects with success.


This change is Reviewable

Copy link
Member

@jkasten2 jkasten2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ludufre Thanks for the PR and sharing a working solution! I took a quick look at the code and I see a lot of hard coded string replacements. This would be quite hard to maintain this code when changes are needed. There might be some JS library that does the parsing and editing of xcode projects in a more schematic way.

Before you put time into clearing this PR up, something we are also considering too is if tooling for something like this could be created for any project (not just Cordova based one).

Feel free to keep sharing this to others as it gives them an automated solution today!

@ludufre
Copy link
Author

ludufre commented Oct 17, 2021

Outdated

@ludufre ludufre closed this Oct 17, 2021
@sevkonline
Copy link

Same problem.. configuring xcode after every rebuild is really tiring and costly. Is there no way to do the Xcode configuration automatically?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants