Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tentacle writes all logs in the default log file instead of the instance log file #739

Open
1 task done
sburmanoctopus opened this issue Dec 14, 2023 · 0 comments
Open
1 task done
Labels
team/server-at-scale Represents the Server at Scale team under the Hosting & Execution Group

Comments

@sburmanoctopus
Copy link
Contributor

Team

  • I've assigned a team label to this issue

What happened?

When starting Tentacle, sometimes it will log in the OctopusTentacle.txt file located in the default location (which is used by all Tentacles on that machine) rather than the OctopusTentacle.txt file located in the instance-specific directory.

Because logging should occur in the instance specific directory, this bug can make it looks like logging is not working. Whereas really it is (just in a different log file).

Reproduction

We have found that this will happen whenever something causes instance loading to throw an exception. For example, adding and deleting lots of instances when one instance is trying to start up.

Error and Stacktrace

No response

More Information

The issue stems from where we initialize logging. We only initialize logging correctly if we successfully determine if we can load the current instance.

But while determining if we can load the current instance, if the error comes from something unrelated to loading our instance, it will fail the whole method and leave logging as it is (i.e. going to the default location).

Workaround

No response

@sburmanoctopus sburmanoctopus added the team/server-at-scale Represents the Server at Scale team under the Hosting & Execution Group label Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team/server-at-scale Represents the Server at Scale team under the Hosting & Execution Group
Projects
None yet
Development

No branches or pull requests

1 participant