API links collection for environment machines missing id

[MarkSiedle]

When searching for machines in a given environment, the links collection that is returned from the API is missing the environmentId in everything except the "Template". In our web-portal, we load all and then do local-paging ourself (so we don't use these paging links), but other clients may be expecting these to work (E.g. wanting to do this from PowerShell via Octopus.Clients is a very likely case).

Note: the missing /{id}/ and filter parameters for the various Self and Page. links.

{
"ItemType": "Machine",
"IsStale": false,
"TotalResults": 0,
"ItemsPerPage": 20,
"NumberOfPages": 1,
"LastPageNumber": 0,
"Items": [],
"Links": {
"Self": "/api/environments//machines",
"Template": "/api/environments/{id}/machines{?skip,take,partialName,roles,isDisabled,healthStatuses,commStyles,tenantIds,tenantTags}",
"Page.All": "/api/environments//machines?skip=0&take=2147483647",
"Page.Current": "/api/environments//machines?skip=0&take=20",
"Page.Last": "/api/environments//machines?skip=0&take=20"
}
}

We are handling this situation correctly in other other similar endpoints, such as /api/projects/Projects-341/Releases, so we will need to match this Links collection logic for environment machines.

Source: https://help.octopusdeploy.com/discussions/problems/65461
Source: https://help.octopusdeploy.com/discussions/problems/65459
Source: https://help.octopusdeploy.com/discussions/problems/65832
Related: OctopusDeploy/OctopusClients#213

[josepw]

Is there a patch for this yet? I used these links to auto provision monitoring.

[octoreleasebot]

Release Note: Fixes for paging parameters in API link collections

[MarkSiedle]

Hi @josepw, yes a fix for this will be included in the next minor release.

[josepw]

Which specific version should I look for?

[matt-richardson]

It will be in 4.1.8. The milestone on this issue is the release it's linked to.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. If you think you've found a related issue, please contact our support team so we can triage your issue, and make sure it's handled appropriately.