-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support to encode timelapse videos with H.265 / HEVC #226
Comments
we're installing ffmpeg from the ubuntu repositories, which winds up being
These flags do appear to be part of the ffmpeg configuration in the octoprint image:
I'm not up to speed on actually running ffmpeg with this output option, but I'm wondering if it requires gpu access? That may mean you'd need additional configuration with docker to enable that capability. Have you actually tried to run ffmpeg with those encoding options in the image? If so, what errors or output did you get? I believe the ffmpeg in the image is configured correctly according to ffmpeg documentation, so this may just be more of a documentation isssue once we figure this out. This is the first time this has come up, so we appreciate any information you can provide beyond the feature request, in regards to what you've tried, and what you're results were with those attempts (including error messages or logs when relevant). |
Actually, i missed the part where it said |
I've merged and deployed a new image with Thanks! |
Thanks, giving it a shot. I'm not positive what the best command is to use, some considerations:
Do you know of a way to re-run the timelapse rendering so I can test multiple settings? Also do you know how to add the codec to the drop-down list for easy user selection? (I'd prefer to not have to use a custom ffmpeg command) Starting with: Think I might want to try something closer to what the docs suggest, though: For us this would be something like: Unrelated, but to further save on unnecessary filesize I may want to reduce the resolution (no need for 1080p timelapse videos) using something like: |
Well, my first one made a file, and the file size is ~45% of MP4 size, but it doesn't play in Quicktime, though does play in VLC.
Going to see if I can figure out why Quicktime / browser won't play it. |
Got it! For hevc this must be included: So the full modified line, with bitrate removed and Thanks for adding the codec support! Do you know how we can go about making this an "official" option that's easy to select? |
Well, if you're interested in doing a PR, then here's what I'd probably do.
This is the basic approach mind you, there might be more logic needed there. If this isn't something you can contribute, go ahead and open a feature request issue for |
Hey @LongLiveCHIEF thanks for the steps though I'm totally sure how to go about it. I've filed a new issue as you suggested: #228 |
Describe the solution you'd like
To have smaller timelapse video files to share when the print is done, it'd be great if we could start encoding with H.265 / HEVC. This will result in essentially the same quality video, but much smaller file size.
I understand the ffmpeg command line is now editable, but don't believe the Octoprint docker package ships with ffmpeg capable of h.265 encoding, so it would have to be re-compiled. Ideally H.265 could be a simple selection in the drop-down of advanced timelapse settings.
Additional context
Asked on OctoPrint github and was directed to send the request here:
OctoPrint/OctoPrint#4538
The text was updated successfully, but these errors were encountered: