Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New metrics and thresholds for streaming delta #361

Open
ioguix opened this issue Nov 29, 2023 · 2 comments
Open

New metrics and thresholds for streaming delta #361

ioguix opened this issue Nov 29, 2023 · 2 comments
Assignees

Comments

@ioguix
Copy link
Member

ioguix commented Nov 29, 2023

Hi,

Since v10, pg_stat_replication includes three new metrics: write_lag, flush_lag and replay_lag.

At the very least, these three metrics should be included in perfdata.

Moreover, we could adapt the current threshold format to label the field the thresholds apply on, the way we do for eg. backends_status. this would support: write_lsn, flush_lsn, replay_lsn, write_lag, flush_lag, replay_lag.

Also, we should keep compatibility with current format. Here are some exemples:

Old format New format
-w 2GB -w flush_lsn=2GB,replay_lsn=2GB
-w 2GB,1GB -w flush_lsn=2GB,replay_lsn=1GB
N/A -w flush_lsn=2GB,flush_lag=1m
N/A -w replay_lsn=2GB,replay_lag=1m
@Krysztophe
Copy link
Collaborator

👍

@ioguix
Copy link
Member Author

ioguix commented Nov 29, 2023

This future work would also answer the feature request from PR #206

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants