-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LRU cache #696
Comments
Reminder, that |
It does. But I think we need to be careful about communicators. I think that we need basically to have an LRU cache per communicator. Otherwise eviction won't be collective. |
Natural thing to do is to hook the cache on the communicator as an MPI attribute then. |
Good suggestion, thanks! I still need to decide on the right API. I would quite like to implement this in tandem with my idea for a "cache manager" (#693). |
Remember to do so on the inner "PyOP2" comm. |
Closing as solved by #724 |
We should introduce an LRU cache object/function to prevent unbounded memory usage by our in-memory caches. We will need to be careful about including the communicator in the cache key somehow so we never evict items from some ranks but not others.
Related issue #693.
Related discussion firedrakeproject/firedrake#2865
The text was updated successfully, but these errors were encountered: