Fixing when to add DependsOnIds. Fixes #3150 #3153
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xing when to add DependsOnIds. Add DependOnIds to missing code paths. Fixes OData#3150
uffelauesen
changed the title
|
@uffelauesen Can you kindly add some few tests to demonstrate this fix. |
gathogojr
requested review from
marabooy,
habbes,
xuzhg,
WanjohiSammy,
gathogojr and
DButoyez
|
@WanjohiSammy |
|
@WanjohiSammy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resetting DependOnIds Fixes #3150
Issues
This pull request fixes #3150
Description
Briefly describe the changes of this pull request.
Resetting DependOnIds in BaseSaveResult and ObjectMaterializerLog.
Fixing when to add DependsOnIds.
Add DependOnIds to missing code paths.
Checklist (Uncheck if it is not completed)
Additional work necessary
If documentation update is needed, please add "Docs Needed" label to the issue and provide details about the required document change in the issue.